Closed
Bug 1193546
Opened 10 years ago
Closed 9 years ago
Warnings-as-errors for clang-cl are not completely disabled
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox43 fixed)
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file, 1 obsolete file)
2.69 KB,
patch
|
glandium
:
review+
jesup
:
feedback+
|
Details | Diff | Splinter Review |
The fix in bug 1090497 didn't disable warnings-as-errors for cases like https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/signaling.gyp#204
Comment 2•10 years ago
|
||
There is actually something fundamentally wrong with signaling.gyp adding WARNINGS_AS_ERRORS this way. /That/ is what should be fixed.
Comment 3•10 years ago
|
||
That line you're linking should be removed and something like the following added to the media/webrtc/moz.build:
GYP_DIRS['signaling'].sandbox_vars['FAIL_ON_WARNINGS'] = True
(and the same for other GYP_DIRS using signaling.gyp)
Assignee: nobody → dmajor
Attachment #8646633 -
Attachment is obsolete: true
Attachment #8647174 -
Flags: review?(mh+mozilla)
Comment 6•9 years ago
|
||
Comment on attachment 8647174 [details] [diff] [review]
patch v2
Review of attachment 8647174 [details] [diff] [review]:
-----------------------------------------------------------------
Thank you
Attachment #8647174 -
Flags: review?(mh+mozilla) → review+
Comment on attachment 8647174 [details] [diff] [review]
patch v2
I feel like I should at least notify someone from webrtc before landing this.
Attachment #8647174 -
Flags: feedback?(rjesup)
Updated•9 years ago
|
Attachment #8647174 -
Flags: feedback?(rjesup) → feedback+
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•