Warnings-as-errors for clang-cl are not completely disabled

RESOLVED FIXED in Firefox 43

Status

()

Core
Build Config
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dmajor, Assigned: dmajor)

Tracking

(Blocks: 1 bug)

42 Branch
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
The fix in bug 1090497 didn't disable warnings-as-errors for cases like https://dxr.mozilla.org/mozilla-central/source/media/webrtc/signaling/signaling.gyp#204
(Assignee)

Comment 1

3 years ago
Created attachment 8646633 [details] [diff] [review]
patch
There is actually something fundamentally wrong with signaling.gyp adding WARNINGS_AS_ERRORS this way. /That/ is what should be fixed.
That line you're linking should be removed and something like the following added to the media/webrtc/moz.build:
   GYP_DIRS['signaling'].sandbox_vars['FAIL_ON_WARNINGS'] = True
(and the same for other GYP_DIRS using signaling.gyp)
(Assignee)

Comment 4

3 years ago
Created attachment 8647174 [details] [diff] [review]
patch v2
Assignee: nobody → dmajor
Attachment #8646633 - Attachment is obsolete: true
Attachment #8647174 - Flags: review?(mh+mozilla)
(Assignee)

Comment 5

3 years ago
I tested that a warning still caused me to fail.
Comment on attachment 8647174 [details] [diff] [review]
patch v2

Review of attachment 8647174 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you
Attachment #8647174 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 7

3 years ago
Comment on attachment 8647174 [details] [diff] [review]
patch v2

I feel like I should at least notify someone from webrtc before landing this.
Attachment #8647174 - Flags: feedback?(rjesup)

Updated

3 years ago
Attachment #8647174 - Flags: feedback?(rjesup) → feedback+
https://hg.mozilla.org/mozilla-central/rev/63602bea8357
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.