Closed Bug 1193546 Opened 10 years ago Closed 9 years ago

Warnings-as-errors for clang-cl are not completely disabled

Categories

(Firefox Build System :: General, defect)

42 Branch
defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: away, Assigned: away)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
There is actually something fundamentally wrong with signaling.gyp adding WARNINGS_AS_ERRORS this way. /That/ is what should be fixed.
That line you're linking should be removed and something like the following added to the media/webrtc/moz.build: GYP_DIRS['signaling'].sandbox_vars['FAIL_ON_WARNINGS'] = True (and the same for other GYP_DIRS using signaling.gyp)
Attached patch patch v2Splinter Review
Assignee: nobody → dmajor
Attachment #8646633 - Attachment is obsolete: true
Attachment #8647174 - Flags: review?(mh+mozilla)
I tested that a warning still caused me to fail.
Comment on attachment 8647174 [details] [diff] [review] patch v2 Review of attachment 8647174 [details] [diff] [review]: ----------------------------------------------------------------- Thank you
Attachment #8647174 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8647174 [details] [diff] [review] patch v2 I feel like I should at least notify someone from webrtc before landing this.
Attachment #8647174 - Flags: feedback?(rjesup)
Attachment #8647174 - Flags: feedback?(rjesup) → feedback+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: