1193580 - Optimize icons

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

I didn't realize I should optimize the new doorhanger/urlbar images.

Comment 1

[Chenxia Liu [:liuche]]

Just talked to mcomella and apparently he's doing this for all the icons, so renaming this bug.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Like bug 1150974 before it. Notably I used trimage before, rather than ImageOptim, so we may get some wins from using additional algos.

ImageOptim claims ~87KB improvement but my filesytem sees more on the resultant APK (42897147k - 42895727k = 1420k)

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1193580 - Losslessly compress png assets. r=liuche

Bug 1193580 - Losslessly compress png assets. r=liuche

Comment 4

[Chenxia Liu [:liuche]]

Comment on attachment 8646666 [details]
MozReview Request: Bug 1193580 - Losslessly compress png assets. r=liuche

https://reviewboard.mozilla.org/r/15825/#review14109

r+, if you also compress the images in mobile/android/themes/ and mobile/android/branding

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

url:        https://hg.mozilla.org/integration/fx-team/rev/1c1d97b563f410d571e4925dab3f53fcae6c5272
changeset:  1c1d97b563f410d571e4925dab3f53fcae6c5272
user:       Michael Comella <[e-mail]>
date:       Tue Aug 11 16:52:38 2015 -0700
description:
Bug 1193580 - Losslessly compress png assets. r=liuche

Comment 6

[Chenxia Liu [:liuche]]

10kb saved :)

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1c1d97b563f4

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This will make be redo (via rebase) pretty much every file in bug 1150742, which will take hours so I'm going to back this out, rerun the algorithm, and reland it after I land bug 1150742.

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

url:        https://hg.mozilla.org/integration/fx-team/rev/a9edaaee5c81016239e9383c86568f1666d860a4
changeset:  a9edaaee5c81016239e9383c86568f1666d860a4
user:       Michael Comella <[e-mail]>
date:       Thu Aug 13 10:27:24 2015 -0700
description:
Bug 1193580 - Backout changeset 1c1d97b563f410d571e4925dab3f53fcae6c5272.

This is temporary and only to easy the landing of bug 1150742.

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(Added as a dep because it could make future backouts/changes messy)

Comment 11

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

url:        https://hg.mozilla.org/integration/fx-team/rev/bdb441abebf03c379b538e388f16f722e7fefa96
changeset:  bdb441abebf03c379b538e388f16f722e7fefa96
user:       Michael Comella <[e-mail]>
date:       Thu Aug 13 10:43:51 2015 -0700
description:
Bug 1193580 - Losslessy compress png assets. r=liuche

Note that this not the originally reviewed patch in the bug, but a re-run of
the algorithm that produced that patch.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a9edaaee5c81
https://hg.mozilla.org/mozilla-central/rev/bdb441abebf0

Comment 13

[Nathan Toone [:toonetown]]

You mention that you ran ImageOptim here, rather than trimage...care to share the command you ran this time?

Comment 14

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Nathan Toone from comment #13)
> You mention that you ran ImageOptim here, rather than trimage...care to
> share the command you ran this time?

I used the GUI as the ImageOptim CL is verbose.