Closed
Bug 1193606
Opened 10 years ago
Closed 10 years ago
Clean up LazyFunction case of tryConvertFreeName and remove JSScript::directlyInEval
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: shu, Assigned: shu)
Details
Attachments
(1 file)
|
19.43 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
With the static scope chain being more sensible nowadays, we can clean up tryConvertFreeName. We can also get rid of the directlyInEval flag, which seems to be used only for not converting free names through eval() when emitting lazy scripts.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8646737 -
Flags: review?(bhackett1024)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → shu
Status: NEW → ASSIGNED
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8646737 [details] [diff] [review]
Clean up LazyFunction case of tryConvertFreeName and remove directlyInEval.
Review of attachment 8646737 [details] [diff] [review]:
-----------------------------------------------------------------
Nice!
::: js/src/vm/ScopeObject.cpp
@@ +5,5 @@
> * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>
> #include "vm/ScopeObject-inl.h"
>
> +#include "mozilla/Maybe.h"
ScopeObject.h now includes Maybe.h, so this file shouldn't need to.
Attachment #8646737 -
Flags: review?(bhackett1024) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•