Closed
Bug 1193618
Opened 9 years ago
Closed 9 years ago
Convert keyboard checkboxes to use gaia-checkbox
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kgrandon, Assigned: kgrandon)
Details
Attachments
(1 file)
In preparation for moving to web components.
|
||
Comment 1•9 years ago
|
||
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8647002 [details] [review] [gaia] KevinGrandon:bug_1193618_keyboard_checkboxes > mozilla-b2g:master Tim or Jan - just looking for a review here if you guys have time. Whoever gets to it first. Thank you very much!
Attachment #8647002 -
Flags: review?(timdream)
Attachment #8647002 -
Flags: review?(janjongboom)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8647002 [details] [review] [gaia] KevinGrandon:bug_1193618_keyboard_checkboxes > mozilla-b2g:master Have you verify the patch with RTL? (I've verified other HTML in apps/keyboard does not contain checkboxes)
Attachment #8647002 -
Flags: review?(timdream)
Attachment #8647002 -
Flags: review?(janjongboom)
Attachment #8647002 -
Flags: review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
> Have you verify the patch with RTL? Yes, everything should work by default in RTL because this is a web component and support has already been added. Thanks for the review. In master: https://github.com/mozilla-b2g/gaia/commit/025b83e444ed2c6e8b12a141b452d441f2a845b4
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•