The default bug view has changed. See this FAQ.

Port bug 1173738 and following bugs to TB (Update URL and search bar borders on Windows 10)

RESOLVED FIXED in Thunderbird 43.0

Status

Thunderbird
Theme
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 43.0
All
Windows 10

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

2 years ago
FX has changed the the search fields for Windows 10 like background- and border colors. Windows 10 has also a 2px border when focused. The taller search fields (28px instead of 24px) needs also to make the toolbarbuttons taller to look even.

I also changed the autocomplete popup to use only a 1px border instead of the default 3px border.

But all the logic is a copy of the FX bugs:
Bug 1173738 - Update URL and search bar borders on Windows 10
Bug 1173747 - URL and search bar autocomplete popup's border should be lighter on Windows 10
Bug 1180260 - 2px border on url bar and search field looks uneven
Bug 1185956 - Windows 10: border-color and box-shadow of URL bar and search field should be animated
(Assignee)

Comment 1

2 years ago
Created attachment 8646849 [details] [diff] [review]
searchBar.patch

Aleth, I've chosen you because it also affects the chat search bar in TB's chat.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8646849 - Flags: review?(aleth)

Comment 2

2 years ago
Comment on attachment 8646849 [details] [diff] [review]
searchBar.patch

Review of attachment 8646849 [details] [diff] [review]:
-----------------------------------------------------------------

I can't usefully review these as I can't test on Windows. If need be, you can rs=me if it is a straightforward port.
Attachment #8646849 - Flags: review?(aleth) → review?(clokep)
I'll get to this when I have access to a Windows machine! Just wanted to let you know I'm not ignoring it.
(Assignee)

Comment 4

2 years ago
Created attachment 8647505 [details] [diff] [review]
searchBar.patch

No hurry, I updated the commit message and made this patch to apply after bug 1193679 to not blocking the other for landing.
Attachment #8646849 - Attachment is obsolete: true
Attachment #8646849 - Flags: review?(clokep)
Attachment #8647505 - Flags: review?(clokep)
(Assignee)

Comment 5

2 years ago
Created attachment 8648387 [details] [diff] [review]
searchBar.patch

I added the new bug 1194943 to this patch.
Attachment #8647505 - Attachment is obsolete: true
Attachment #8647505 - Flags: review?(clokep)
Attachment #8648387 - Flags: review?(clokep)
(Assignee)

Comment 6

2 years ago
A try build can be found here: https://ftp-ssl.mozilla.org/pub/mozilla.org/thunderbird/try-builds/richard.marti@gmail.com-370ac4a969a7
Comment on attachment 8648387 [details] [diff] [review]
searchBar.patch

I was able to play with the try build today and the changes are subtle, but there. Looks a better!
Attachment #8648387 - Flags: review?(clokep) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Comment 8

2 years ago
Created attachment 8654494 [details] [diff] [review]
searchBar.patch

Bug 1194943 made a late change after my patch got r+. I adapted this changes in this patch.

Patrick, do you want a new review or is it okay to land it?
Attachment #8648387 - Attachment is obsolete: true
Flags: needinfo?(clokep)
(Assignee)

Comment 9

2 years ago
The interdiff shows more changes because the previous patch had wrong indentations.
Paenglab. You can carry my review forward. Thanks!
Flags: needinfo?(clokep)
(Assignee)

Comment 11

2 years ago
Comment on attachment 8654494 [details] [diff] [review]
searchBar.patch

Carrying the r+ from previous patch.
Attachment #8654494 - Flags: review+

Comment 12

2 years ago
https://hg.mozilla.org/comm-central/rev/e8257356d0e5b1a2e58f2a6e847b6847120e8b63
Bug 1193679 - Port bug 1173738 and following bugs to TB (Update URL and search bar borders on Windows 10). r=clokep

Updated

2 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 43.0
You need to log in before you can comment on or make changes to this bug.