I's hard to see the hovered treeitems in the sidebars on Windows 10

RESOLVED FIXED in Thunderbird 43.0

Status

Thunderbird
Theme
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 43.0
All
Windows 10

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Created attachment 8646854 [details]
Screenshot of before and with patch

The sidebar background color -moz-Dialog is too dark for Windows 10 which is using very light backgrounds. The hovered treeitems are are almost not visible with the actual background color.

See the screenshot with the actual and the with the patch applied sidebar.
(Assignee)

Comment 1

2 years ago
Created attachment 8646858 [details] [diff] [review]
sidebarColorW10.patch

Aleth, again I've chosen you because it has again changes in chat part of TB.

I had also to make the .im-placeholder-screen lighter to match the sidebar.

This patch needs bug 1193679 applied first to not rot the other patch.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8646858 - Flags: review?(aleth)

Comment 2

2 years ago
Comment on attachment 8646858 [details] [diff] [review]
sidebarColorW10.patch

Review of attachment 8646858 [details] [diff] [review]:
-----------------------------------------------------------------

I can't usefully review these as I can't test on Windows. If need be, you can rs=me.
Attachment #8646858 - Flags: review?(aleth) → review?(clokep)
Comment on attachment 8646858 [details] [diff] [review]
sidebarColorW10.patch

Review of attachment 8646858 [details] [diff] [review]:
-----------------------------------------------------------------

I cannot test this at the moment, but the screenshot looks fine and the code is reasonable.
Attachment #8646858 - Flags: review?(clokep) → review+
(Assignee)

Comment 4

2 years ago
Created attachment 8647504 [details] [diff] [review]
sidebarColorW10.patch

Updated the commit message and made the patch applying without applying bug 1193679 first.
Attachment #8646858 - Attachment is obsolete: true
Attachment #8647504 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

2 years ago
http://hg.mozilla.org/comm-central/rev/3cd7a66f23bc
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 43.0
You need to log in before you can comment on or make changes to this bug.