1193682 - I's hard to see the hovered treeitems in the sidebars on Windows 10

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

Attachment: Screenshot of before and with patch

The sidebar background color -moz-Dialog is too dark for Windows 10 which is using very light backgrounds. The hovered treeitems are are almost not visible with the actual background color.

See the screenshot with the actual and the with the patch applied sidebar.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: sidebarColorW10.patch

Aleth, again I've chosen you because it has again changes in chat part of TB.

I had also to make the .im-placeholder-screen lighter to match the sidebar.

This patch needs bug 1193679 applied first to not rot the other patch.

Comment 2

[aleth [:aleth]]

Comment on attachment 8646858 [details] [diff] [review]
sidebarColorW10.patch

Review of attachment 8646858 [details] [diff] [review]:
-----------------------------------------------------------------

I can't usefully review these as I can't test on Windows. If need be, you can rs=me.

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 8646858 [details] [diff] [review]
sidebarColorW10.patch

Review of attachment 8646858 [details] [diff] [review]:
-----------------------------------------------------------------

I cannot test this at the moment, but the screenshot looks fine and the code is reasonable.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: sidebarColorW10.patch

Updated the commit message and made the patch applying without applying bug 1193679 first.

Comment 5

[Richard Marti (:Paenglab)]

http://hg.mozilla.org/comm-central/rev/3cd7a66f23bc