Closed Bug 1193682 Opened 5 years ago Closed 5 years ago

I's hard to see the hovered treeitems in the sidebars on Windows 10

Categories

(Thunderbird :: Theme, defect)

All
Windows 10
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 43.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files, 1 obsolete file)

The sidebar background color -moz-Dialog is too dark for Windows 10 which is using very light backgrounds. The hovered treeitems are are almost not visible with the actual background color.

See the screenshot with the actual and the with the patch applied sidebar.
Attached patch sidebarColorW10.patch (obsolete) — Splinter Review
Aleth, again I've chosen you because it has again changes in chat part of TB.

I had also to make the .im-placeholder-screen lighter to match the sidebar.

This patch needs bug 1193679 applied first to not rot the other patch.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8646858 - Flags: review?(aleth)
Comment on attachment 8646858 [details] [diff] [review]
sidebarColorW10.patch

Review of attachment 8646858 [details] [diff] [review]:
-----------------------------------------------------------------

I can't usefully review these as I can't test on Windows. If need be, you can rs=me.
Attachment #8646858 - Flags: review?(aleth) → review?(clokep)
Comment on attachment 8646858 [details] [diff] [review]
sidebarColorW10.patch

Review of attachment 8646858 [details] [diff] [review]:
-----------------------------------------------------------------

I cannot test this at the moment, but the screenshot looks fine and the code is reasonable.
Attachment #8646858 - Flags: review?(clokep) → review+
Updated the commit message and made the patch applying without applying bug 1193679 first.
Attachment #8646858 - Attachment is obsolete: true
Attachment #8647504 - Flags: review+
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/3cd7a66f23bc
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 43.0
You need to log in before you can comment on or make changes to this bug.