119369 - NSS doesn't support internationalization

Status: CLOSED WORKSFORME

(Core :: Security, defect)

Description

[xspuente]

I'm using Mozilla 0.9.7, and also with 0.9.6 I had problems with the security
features when using the Asturian langpack. I'm a l10n contributor, and Andrea
has taken a look at my langpack and looks that the NSS component (in particular
/pipnss/pipnss.poperties/PrivateTokenDescription = "Dispositivu de Seguridá del
Software") is unable to handle non-English characters (i.e. accentuated ones in
this case).

Steps to reproduce:
- Using Mozilla 0.9.7 download and install the Asturian langpack
(http://www.asturies.org/viesca/software/mozilla/LANGASTAS.XPI)
- Switch language to Asturian.
- Go to Preferences | Privacy & Security | Master Password, and try to change
the Master Password or Reset it.

- Expected result: if you reset the Master Password, you click Reset and works.
- Observed result: you click Reset and nothing happens.

- Switch language to English.
- Repeat previous steps.
- Everything works fine.

Andrea told me that if she changes "seguridá" for "segurida" (no accents),
everything works fine.

Comment 1

[Frank Tang]

that property is used by the following places according to lxr.mozilla.org
/security/manager/ssl/src/nsNSSComponent.cpp, line 404 -- nsXPIDLString
privateTokenDescription;
/security/manager/ssl/src/nsNSSComponent.cpp, line 423 -- rv =
GetPIPNSSBundleString(NS_LITERAL_STRING("PrivateTokenDescription").get(),
/security/manager/ssl/src/nsNSSComponent.cpp, line 424 --
getter_Copies(privateTokenDescription));
/security/manager/ssl/src/nsNSSComponent.cpp, line 446 --
NS_LossyConvertUCS2toASCII(privateTokenDescription).get(),

cvsblame show [e-mail] are the last one change those lines. give to kaie.
nomiate for nsbeta1

Comment 2

[Kai Engert [:KaiE:]]

I can't reproduce the problem.

I changed the text privateTokenDescription to the accented string
  Dispositivu de Seguridá del Software
and it worked.

I believe it is now fixed, because looking at the history of that file, on 21
Dec 2001 the strings are now converted using NS_LossyConvertUCS2toASCII before
they are given to NSS. This might prevent the problems you see.

Marking worksforme. If you can, please retest with a newer build. Thanks.

Comment 3

[xspuente]

I don't see this problem with 0.9.8, although I didn't have the time to change
all the strings I had to change for 0.9.7 to work. I'm closing the bug since it
works with 0.9.8 and the way that the strings are given to NSS had also changed.