1193690 - Use the global close icon for Tabs

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Richard Marti (:Paenglab)]

FX is using the close icons from global/icons. When we switch to this icons for the tabs we get automatically the icons FX is using and we have then also the HiDPI versions automatically.

Referenced bugs:
Bug 1168528 - Tab close icons on Windows HiDPI are blurry
Bug 1173729 - Update generic close icon and new tab button icon on Windows 10

Comment 1

[Richard Marti (:Paenglab)]

Attachment: globalIcon.patch

I've built and tested this patch on Linux and Windows. On OS X I patched the omni.ja to test.

Philipp, if you can build and test this on OS X then we can be sure it works everywhere.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 8646864 [details] [diff] [review]
globalIcon.patch

Review of attachment 8646864 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks fine, so r+ for now. My builds are messed up at the moment, I'd have to clobber to test this. Maybe you can start a try build instead?

Comment 3

[Richard Marti (:Paenglab)]

The Nightlies aren't also not building, but this seems to be a infra issue.

Try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1baa4272df6d

Comment 4

[Richard Marti (:Paenglab)]

(In reply to Richard Marti (:Paenglab) from comment #3)
> The Nightlies aren't also not building, but this seems to be a infra issue.
> 
> Try:
> https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1baa4272df6d

The try build failed too on OS X.

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/1d40ee3eb12d433ef53e5052147186aab53555f9
Bug 1193690 - Use the global close icon for Tabs. r=Fallen