Closed Bug 1193690 Opened 5 years ago Closed 4 years ago

Use the global close icon for Tabs

Categories

(Thunderbird :: Theme, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 43.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

FX is using the close icons from global/icons. When we switch to this icons for the tabs we get automatically the icons FX is using and we have then also the HiDPI versions automatically.

Referenced bugs:
Bug 1168528 - Tab close icons on Windows HiDPI are blurry
Bug 1173729 - Update generic close icon and new tab button icon on Windows 10
Attached patch globalIcon.patchSplinter Review
I've built and tested this patch on Linux and Windows. On OS X I patched the omni.ja to test.

Philipp, if you can build and test this on OS X then we can be sure it works everywhere.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8646864 - Flags: review?(philipp)
Comment on attachment 8646864 [details] [diff] [review]
globalIcon.patch

Review of attachment 8646864 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks fine, so r+ for now. My builds are messed up at the moment, I'd have to clobber to test this. Maybe you can start a try build instead?
Attachment #8646864 - Flags: review?(philipp) → review+
The Nightlies aren't also not building, but this seems to be a infra issue.

Try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1baa4272df6d
(In reply to Richard Marti (:Paenglab) from comment #3)
> The Nightlies aren't also not building, but this seems to be a infra issue.
> 
> Try:
> https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1baa4272df6d

The try build failed too on OS X.
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 43.0
You need to log in before you can comment on or make changes to this bug.