119373 - workaround apache double-zip bug when sending .zip files (duplicate the double-gzip logic in nsHttpChannel.cpp)

Status: RESOLVED INVALID

(Core :: Networking, defect)

Description

[Darin Fisher]

workaround apache double-zip bug when sending .zip files (duplicate the
double-gzip logic in nsHttpChannel.cpp).

see nsHttpChannel::ProcessNormal()

bz says apache does not exhibit this bug by default... only if configured to
automatically send "Content-Encoding: deflate" for .zip files.

the same logic should probably be in place for compress as well.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Oh, and "compress" is _on_ by default, by the way.  At least in the default
RedHat 6.2 Apache install....

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

So... the site sends the file as application/x-gunzip.	The patch adds that to
the nsHttpChannel "apache is broken" logic and adds postscript to the list of
types not to decode (a good idea anyway, imo).

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 71814 [details] [diff] [review]
Proposed fix

um... wrong bug.  :(

Comment 4

[Darin Fisher]

-> future

Comment 5

[Darin Fisher]

-> default owner

Comment 6

[Matthias Versen [:Matti]]

Boris: Is this bug fixed by bug 717524 ?

Comment 7

[Boris Zbarsky [:bzbarsky]]

No.  That bug is about doubled gzip content-encoding.  This bug is about a misconfigured server claiming that a .zip file is content-encoded with "compress", which causes us to decompress it when we should not.

Comment 8

[Patrick McManus [:mcmanus]]

I'm going to close this without a gecko change. the server is at fault, and we aren't overrun with this report so there is no reason to implement a workaround for it.