Closed Bug 1193785 Opened 5 years ago Closed 5 years ago

Create Imagecompare RTL test for Settings:Privacy and Security

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: njpark, Assigned: njpark)

Details

Attachments

(3 files)

Create Imagecompare script that covers the Privacy and Security section of Settings app
Assignee: nobody → npark
No longer depends on: 1189378, 1192967
Attachment #8648900 - Flags: review?(martijn.martijn)
Comment on attachment 8648900 [details] [review]
[gaia] npark-mozilla:1193785 > mozilla-b2g:master

Looks good, I couldn't find anything wrong with the pull request and in local testing, the test was passing.
Attachment #8648900 - Flags: review?(martijn.martijn) → review+
Merged:

https://github.com/mozilla-b2g/gaia/commit/b90dcf6e4fbe40e8e5885634a12b4c7c4ba9e323
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1195992
No longer blocks: 1195992
What I see wrong is that I never authored that commit that got merged.

Care to explain?
Flags: needinfo?(npark)
Seems that when I rebased and squashed commits, it took the author of the first published commit and kept it. Sorry about this.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.