Closed Bug 1193788 Opened 5 years ago Closed 5 years ago

Remove unused variables from performance.dtd

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: linclark, Assigned: linclark)

Details

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:41.0) Gecko/20100101 Firefox/41.0
Build ID: 20150810004008

Steps to reproduce:

The performanceUI.exportButton in performance.dtd seems to be unused. See search below.

https://dxr.mozilla.org/mozilla-central/search?q=path%3Aperformance+exportButton&redirect=false&case=true&limit=63&offset=0

Instead, the label for the button is pulled from performance.properties:

> recordingsList.saveLabel=Save
Attached patch Bug1193788.patch (obsolete) — Splinter Review
Here's a patch that removes what I believe is cruft from performance.dtd.

Is it likely that there are other unused variables in performance.dtd which have been superseded by variables in performance.properties? If so, I could go through and find the other ones as part of this issue.
Attachment #8646968 - Flags: feedback?(jsantell)
Comment on attachment 8646968 [details] [diff] [review]
Bug1193788.patch

Review of attachment 8646968 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Lin! Yeah, we just moved over/combined the timeline and profiler localization strings, so I'm sure there's a few vestigial localizations in these files..

Thanks again!
Attachment #8646968 - Flags: feedback?(jsantell) → feedback+
Assignee: nobody → lin.w.clark
Status: UNCONFIRMED → ASSIGNED
Component: Untriaged → Developer Tools: Performance Tools (Profiler/Timeline)
Ever confirmed: true
Version: 43 Branch → Trunk
Summary: Remove unused variable: performanceUI.exportButton → Remove unused variables from performance.dtd
Attached patch Bug1193788.patchSplinter Review
This patch:
- Removes performanceUI.newtab.tooltiptext and performanceUI.exportButton
- Corrects comments for performanceUI.options.filter.tooltiptext and performanceUI.options.gear.tooltiptext so they use the correct identifier
- Moves toolbar.*.tooltips so that each is below the corresponding toolbar label
Attachment #8646968 - Attachment is obsolete: true
Attachment #8647477 - Flags: review?(jsantell)
Comment on attachment 8647477 [details] [diff] [review]
Bug1193788.patch

Review of attachment 8647477 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great -- thanks again, Lin! Going to run tests locally and push if everything looks good.
Attachment #8647477 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/5d4ae7b9e9d3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.