119385 - Some modern theme images are needlessly transparent

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[Simon Fraser [no longer active]]

I notice that many images in the modern theme (didn't check classic) are
transparent, and need not be. Transparency imposes significant runtime cost,
especially for images that must be tiled (at least on Mac).

Some examples:
mozilla/themes/modern/navigator/icons/btn1.gif
mozilla/themes/modern/global/toolbar/tb-mid.gif  (gets tiled!)

also
mozilla/themes/modern/global/preview.gif

We should probably make a pass through all skin images and ensure that
transparency is off when possible.

Comment 1

[Joe Hewitt (gone)]

-> shliang

Comment 2

[Lori Kaplan]

triage approving performance win

Comment 3

[shliang]

i looked at those images in photoshop and they are not transparent

Comment 4

[Simon Fraser [no longer active]]

The GIFs have transparency.

Comment 5

[Simon Fraser [no longer active]]

Note: I used the GIF Analyzer, from
<ftp://ftp.totallyhip.com/products/GIFUtilityPack/GIFUtilityPack10FAT.bin>
to look at the image. It shows that the 'btn1.gif' is transparent, with 
transparency index 235.

So even if PhotoShop shows no transparency, however you export to .gif is adding 
transparency, needlessly.

Comment 6

[shliang]

Attachment: turning transparency off for those 3 images

going to go through other images now

Comment 7

[andreww]

be careful - some images need to be transparent as far as I know.

Comment 8

[shliang]

Attachment: classic mac preview.gif

Comment 9

[shliang]

Attachment: classic win preview.gif

doesn't look like anything else in modern or classic has transparency if it
doesn't need it

Comment 10

[Joe Hewitt (gone)]

sr=hewitt on all the images

Comment 11

[andreww]

r=andreww for images  listed in this bug.

Comment 12

[shliang]

fixed

Comment 13

[Patty Mac]

Verified on all platforms (commercial build: 2002-02-25-08-trunk)