Closed
Bug 1193860
Opened 9 years ago
Closed 8 years ago
[sync] Escape quotes in DTD files
Categories
(Webtools Graveyard :: Pontoon, defect, P1)
Webtools Graveyard
Pontoon
Tracking
(firefox43 affected)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox43 | --- | affected |
People
(Reporter: mathjazz, Assigned: mathjazz)
Details
To prevent errors like this in the future: https://bugzilla.mozilla.org/show_bug.cgi?id=1193799 Inspiration: https://github.com/translate/translate/blob/master/translate/convert/test_dtd2po.py This is only relevant for mobile/android/base (part of Firefox for Android), but it probably doesn't hurt if we do it for all DTD files.
Assignee | ||
Updated•9 years ago
|
Summary: Escape quotes in DTD files → [sync] Escape quotes in DTD files
Assignee | ||
Updated•9 years ago
|
Priority: -- → P3
Comment 1•8 years ago
|
||
Any chance to raise the priority of this bug? Apparently, it breaks nightly builds for Firefox Aurora.
Assignee | ||
Comment 2•8 years ago
|
||
Gion-Andri, are the errors related to this? https://l10n.mozilla.org/dashboard/compare?run=563338
Comment 3•8 years ago
|
||
I think mainly of the errors related to this: https://l10n.mozilla.org/dashboard/compare?run=563337 [I tried to fix them in http://hg.mozilla.org/releases/l10n/mozilla-aurora/rm/rev/6ac304b05f25 but apparently, I failed for files using single quotes to delimit the strings (my failed attempt is the compare-locales run you referenced in #comment2). I will fix them in a second commit.] But it would be nice, if pontoon could escape the quotes directly and no manual fixing would be necessary.
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Gion-Andri Cantieni [:gion-andri] from comment #3) > But it would be nice, if pontoon could escape the quotes directly and no > manual fixing would be necessary. Agreed, will have a look soon.
Priority: P3 → P1
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → m
Comment 5•8 years ago
|
||
Commits pushed to master at https://github.com/mozilla/pontoon https://github.com/mozilla/pontoon/commit/8f2f091d82920094696bc0838550e8b1b695576d Fix bug 1193860: escape quotes in some DTD files https://github.com/mozilla/pontoon/commit/ef2925bdbfe6833a8270bcdb373c76ab6aec12cf Merge pull request #326 from mathjazz/bug-1193860 Fix bug 1193860: escape quotes in some DTD files
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•