display= doesn't work if extends= is not present

NEW
Unassigned

Status

()

Core
XBL
16 years ago
7 years ago

People

(Reporter: Brian Ryner (not reading), Unassigned)

Tracking

Trunk
Future
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: INVALIDATEME)

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
If you use display= on a binding without also using extends=, display= does not
work, i.e.

<binding id="foo" display="xul:outliner"/>

Updated

16 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → Future

Comment 1

13 years ago
I've a patch for this

Comment 2

13 years ago
Created attachment 152402 [details] [diff] [review]
patch v1

this patch just adds a !hasDisplay to the logic so that it doesn't skip in the
case when hasDisplay is true but hasExtends is false.

Comment 3

13 years ago
My understanding was that this was by design.

Use <binding id="foo" extends="xul:button"> if you don't inherit

Use <binding id="foo" display="xul:button" extends="..."> if you do.
Whiteboard: INVALIDATEME

Comment 4

13 years ago
well in that case can we change the design? Note that even with this patch
<binding id="foo" extends="xul:button"> would still work.
So, is this a valid bug, or not?
Personally, I would like <binding id="foo" display="xul:outliner"/> to work.
QA Contact: jrgmorrison → xbl

Updated

8 years ago
Assignee: hyatt → nobody
This is a mass change. Every comment has "assigned-to-new" in it.

I didn't look through the bugs, so I'm sorry if I change a bug which shouldn't be changed. But I guess these bugs are just bugs that were once assigned and people forgot to change the Status back when unassigning.
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.