Last Comment Bug 119389 - display= doesn't work if extends= is not present
: display= doesn't work if extends= is not present
Status: NEW
INVALIDATEME
:
Product: Core
Classification: Components
Component: XBL (show other bugs)
: Trunk
: All All
: -- normal with 1 vote (vote)
: Future
Assigned To: Nobody; OK to take it and work on it
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2002-01-10 19:03 PST by Brian Ryner (not reading)
Modified: 2010-05-13 10:06 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v1 (2.00 KB, patch)
2004-07-06 04:13 PDT, basic
no flags Details | Diff | Splinter Review

Description Brian Ryner (not reading) 2002-01-10 19:03:27 PST
If you use display= on a binding without also using extends=, display= does not
work, i.e.

<binding id="foo" display="xul:outliner"/>
Comment 1 basic 2004-07-06 04:05:17 PDT
I've a patch for this
Comment 2 basic 2004-07-06 04:13:25 PDT
Created attachment 152402 [details] [diff] [review]
patch v1

this patch just adds a !hasDisplay to the logic so that it doesn't skip in the
case when hasDisplay is true but hasExtends is false.
Comment 3 neil@parkwaycc.co.uk 2004-08-15 12:05:19 PDT
My understanding was that this was by design.

Use <binding id="foo" extends="xul:button"> if you don't inherit

Use <binding id="foo" display="xul:button" extends="..."> if you do.
Comment 4 basic 2004-08-16 09:14:23 PDT
well in that case can we change the design? Note that even with this patch
<binding id="foo" extends="xul:button"> would still work.
Comment 5 Martijn Wargers [:mwargers] (not working for Mozilla) 2005-06-07 03:38:35 PDT
So, is this a valid bug, or not?
Personally, I would like <binding id="foo" display="xul:outliner"/> to work.
Comment 6 Michael Kohler [:mkohler] 2010-05-13 10:06:56 PDT
This is a mass change. Every comment has "assigned-to-new" in it.

I didn't look through the bugs, so I'm sorry if I change a bug which shouldn't be changed. But I guess these bugs are just bugs that were once assigned and people forgot to change the Status back when unassigning.

Note You need to log in before you can comment on or make changes to this bug.