1193951 - Improve the button layout of the Sheriff panel

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P3)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Having all of the buttons use a white background color makes it harder to discern which button does what at a glance.

At a minimum, could we get the "Delete" button in the main "Exclusion profiles"  and "Job Exclusions" sections, and the "Reset" button in the "Create/Update Exclusion Profile" section turned red, since those are destructive actions? (Though "Reset" still takes a "Save" click to actually apply the change...)

I'm less concerned about the other buttons, but I guess the "Change" and "Save" buttons could be blue or green or something?

Comment 1

[Jonathan French (:jfrench)]

While making any color changes, I think we could really improve and economize the layout with something like this:

(Change button)
- each first column cell (Name) content, becomes a link - which elicits the "Change" function, and we retire the Change buttons altogether
- if we want we can place a small blue fa-pencil or whatever in front of the name

(Make Default button)
- Make Default buttons are retired, and clicking in the existing "Default" cell (which already contains a green checkbox) changes the default to that row

(Delete button)
- We change that last "Actions" column to "Delete" (maybe a bg for that cell in bootstrap error red/pink) - and use the same grey/red icon we use in the Annotations tab, here also

If you'd like to assign me, happy to have a go at this if Wes is busy :)

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Have at it.

Comment 3

[Jonathan French (:jfrench)]

Attachment: exclusionProfilePanel_wip1

I made some progress on it this afternoon (attached). Still more work to do. I'd like to remove the panel header and grey boundary area if I can, and use nav-tab for the main links.

Comment 4

[Jonathan French (:jfrench)]

Attachment: PR 933

Wip PR, will add a review flag when it's ready.

Comment 5

[Jonathan French (:jfrench)]

Comment on attachment 8656140 [details] [review]
PR 933

Ready for review.

Comment 6

[Cameron Dawson [:camd]]

Comment on attachment 8656140 [details] [review]
PR 933

This looks great!!

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/adb04912106a92bfd14cde8ac91f65278102c40e
Bug 1193951 - Improve the layout of the Sheriff panel

Comment 8

[Jonathan French (:jfrench)]

Marking fixed per above merge.

Comment 9

[Jonathan French (:jfrench)]

A note, a change made here will also give the Filter panel a white background (it was medium grey prior), but I think this is the direction we'd like to go anyway, per Filter panel improvements proposed in bug 1202003.

Comment 10

[Jonathan French (:jfrench)]

Verified fixed on production. Everything seems well received by RyanVM and sheriffs.