1193973 - The system add-ons that shipped with the app should be loaded in safe mode

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop] (PTO until July 20)]

What should we do with system add-ons in safe mode?

Comment 1

[Dave Townsend [:mossop] (PTO until July 20)]

Attachment: MozReview Request: Bug 1193973: System add-ons that shipped with the app should be loaded in safe mode. r?rhelmer

Bug 1193973: System add-ons that shipped with the app should be loaded in safe mode. r?rhelmer

Comment 2

[Dave Townsend [:mossop] (PTO until July 20)]

Comment on attachment 8665533 [details]
MozReview Request: Bug 1193973: System add-ons that shipped with the app should be loaded in safe mode. r?rhelmer

Actually this isn't quite right yet.

Comment 3

[Dave Townsend [:mossop] (PTO until July 20)]

Comment on attachment 8665533 [details]
MozReview Request: Bug 1193973: System add-ons that shipped with the app should be loaded in safe mode. r?rhelmer

Bug 1193973: System add-ons that shipped with the app should be loaded in safe mode. r?rhelmer

By making the updated system add-on install location return an empty set when
in safe mode it causes us to rescan and enable the default system add-ons.

The complication is calling the uninstall method on the updated add-ons when
switching to safe mode, for that we have to cache the fact that an add-on
can run in safe mode in the bootstrappedAddons data so it persists to the
next restart and can be accessed when the updated add-on has been hidden.

Comment 4

[Robert Helmer [:rhelmer]]

Comment on attachment 8665533 [details]
MozReview Request: Bug 1193973: System add-ons that shipped with the app should be loaded in safe mode. r?rhelmer

https://reviewboard.mozilla.org/r/20251/#review18725

Comment 5

[Dave Townsend [:mossop] (PTO until July 20)]

Comment on attachment 8665533 [details]
MozReview Request: Bug 1193973: System add-ons that shipped with the app should be loaded in safe mode. r?rhelmer

Bug 1193973: System add-ons that shipped with the app should be loaded in safe mode. r?rhelmer

By making the updated system add-on install location return an empty set when
in safe mode it causes us to rescan and enable the default system add-ons.

The complication is calling the uninstall method on the updated add-ons when
switching to safe mode, for that we have to cache the fact that an add-on
can run in safe mode in the bootstrappedAddons data so it persists to the
next restart and can be accessed when the updated add-on has been hidden.

Comment 6

[Dave Townsend [:mossop] (PTO until July 20)]

Comment on attachment 8665533 [details]
MozReview Request: Bug 1193973: System add-ons that shipped with the app should be loaded in safe mode. r?rhelmer

Apparently I didn't run tests on this properly so I had to make some tweaks to fix an issue, see https://reviewboard.mozilla.org/r/20251/diff/2-3/ but you can ignore the bottom two changes listed as they come from rebasing this on top of other stuff that has landed.

Comment 7

[Robert Helmer [:rhelmer]]

Comment on attachment 8665533 [details]
MozReview Request: Bug 1193973: System add-ons that shipped with the app should be loaded in safe mode. r?rhelmer

https://reviewboard.mozilla.org/r/20251/#review18893

::: toolkit/mozapps/extensions/internal/XPIProvider.jsm:4332
(Diff revisions 2 - 3)
> -    let runInSafeMode = "runInSafeMode" in aAddon ? aAddon.runInSafeMode : canRunInSafeMode(aAddon);
> +    let runInSafeMode = ("runInSafeMode" in aAddon) ? aAddon.runInSafeMode : canRunInSafeMode(aAddon);

why are the parens necesssary?

Comment 8

[Dave Townsend [:mossop] (PTO until July 20)]

https://reviewboard.mozilla.org/r/20251/#review18893

> why are the parens necesssary?

Looks like they're not, I can drop that.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/08ae873336b7

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/08ae873336b7