Closed Bug 1193975 Opened 4 years ago Closed 4 years ago

Remove *.NewTablet styles and lean on resource system

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(3 files)

We can lean on the resource system now that we don't have to maintain the old tablet configuration.

This is a follow-up to bug 1150742.
Bug 1193975 - Remove NewTablet from ImageButton style. r=mhaigh

I feel like there's a better way to do this than using *Base, but
this is our current convention.
Attachment #8647231 - Flags: review?(mhaigh)
Bug 1193975 - Remove NewTablet from ImageButton.TabCount. r=mhaigh

It seems the other attributes are not used on tablet so there was
no need to make a base style here.
Attachment #8647232 - Flags: review?(mhaigh)
Bug 1193975 - Remove unused menuItemActionBarStyleNewTablet. r=mhaigh
Attachment #8647233 - Flags: review?(mhaigh)
Comment on attachment 8647231 [details]
MozReview Request: Bug 1193975 - Remove NewTablet from ImageButton style. r=mhaigh

https://reviewboard.mozilla.org/r/15947/#review14241

Ship It!

::: mobile/android/base/resources/values-large-v11/styles.xml
(Diff revision 1)
> -        <!-- From UrlBar.ImageButton.NewTablet because we can't inherit directly. -->

Why was this removed?
Attachment #8647231 - Flags: review?(mhaigh) → review+
Comment on attachment 8647232 [details]
MozReview Request: Bug 1193975 - Remove NewTablet from ImageButton.TabCount. r=mhaigh

https://reviewboard.mozilla.org/r/15949/#review14243

Ship It!
Attachment #8647232 - Flags: review?(mhaigh) → review+
Comment on attachment 8647233 [details]
MozReview Request: Bug 1193975 - Remove unused menuItemActionBarStyleNewTablet. r=mhaigh

https://reviewboard.mozilla.org/r/15951/#review14245

Ship It!
Attachment #8647233 - Flags: review?(mhaigh) → review+
https://reviewboard.mozilla.org/r/15947/#review14241

> Why was this removed?

I originally started removing `UrlBar.ImageButton.TabCount.NewTablet` first, before I realized I should start with `UrlBar.ImageButton.NewTablet`, due to inheritance, and I guess I messed up the commit order. It's probably not worth the time to fix this commit though, as it gets fixed by later commits.
url:        https://hg.mozilla.org/integration/fx-team/rev/33890bfdc26d841480c42d8a7cdd334916fd07f3
changeset:  33890bfdc26d841480c42d8a7cdd334916fd07f3
user:       Michael Comella <michael.l.comella@gmail.com>
date:       Wed Aug 12 16:24:18 2015 -0700
description:
Bug 1193975 - Remove NewTablet from ImageButton style. r=mhaigh

I feel like there's a better way to do this than using *Base, but
this is our current convention.

url:        https://hg.mozilla.org/integration/fx-team/rev/9b6e54ff3cb3e3cc093114652d8bbd99baf27141
changeset:  9b6e54ff3cb3e3cc093114652d8bbd99baf27141
user:       Michael Comella <michael.l.comella@gmail.com>
date:       Wed Aug 12 16:29:01 2015 -0700
description:
Bug 1193975 - Remove NewTablet from ImageButton.TabCount. r=mhaigh

It seems the other attributes are not used on tablet so there was
no need to make a base style here.

url:        https://hg.mozilla.org/integration/fx-team/rev/26c0c36598ca467ad706c9fafcf414465e69a040
changeset:  26c0c36598ca467ad706c9fafcf414465e69a040
user:       Michael Comella <michael.l.comella@gmail.com>
date:       Wed Aug 12 16:31:32 2015 -0700
description:
Bug 1193975 - Remove unused menuItemActionBarStyleNewTablet. r=mhaigh
You need to log in before you can comment on or make changes to this bug.