1193989 - Translations break sync preferences layout

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Edouard Oger [:eoger]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1149721#c38

Comment 1

[Edouard Oger [:eoger]]

Attachment: bug-1193989.patch

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8647186 [details] [diff] [review]
bug-1193989.patch

Review of attachment 8647186 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM - if you aren't 100% sure this will fix the issue, you could consider pushing a try build and asking the localiser to test it for you - your call.

::: browser/components/preferences/in-content/sync.xul
@@ +226,3 @@
>      </hbox>
> +    <label class="fxaMobilePromo">
> +        &mobilePromo.start;<image class="androidLogo"/><label class="androidLink text-link" href="https://www.mozilla.org/firefox/android/">&mobilePromo.androidLink;</label>&mobilePromo.end;

can we break this line?

Comment 4

[Edouard Oger [:eoger]]

Attachment: Screen Shot 2015-08-12 at 1.50.41 PM.png

We cannot, it will insert unwanted spaces.
After extended testing, I'm fairly confident this will resolve the issues.

Comment 5

[Edouard Oger [:eoger]]

Stefan can you test this build? https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-dafb14cb1e76

Comment 6

[Edouard Oger [:eoger]]

Attachment: bug-1193989.patch

I found a way to break the big android promo line Mark :)

Comment 7

[Stefan Plewako [:stef]]

Yes, this fixes margin/space after mobilePromo.androidLink and sync-illustration bottom margin issues, thx!

Comment 8

[Edouard Oger [:eoger]]

You can also use a longer string for "Connect with a Firefox Account" Stefan, the wrapping box will stretch without any issues.

Comment 9

[Stefan Plewako [:stef]]

(In reply to Edouard Oger [:eoger] from comment #8)
> You can also use a longer string for "Connect with a Firefox Account"
> Stefan, the wrapping box will stretch without any issues.

Unfortunately not, "Firefox Account" is variable and translated in pl as "Konto Firefoksa" but "Connect with a Firefox Account" should be translated as "Połącz z kontem Firefoksa".

Comment 10

[Edouard Oger [:eoger]]

We will want to uplift this to Aurora in a week or so.

Comment 11

[Mark Hammond [:markh] [:mhammond]]

ni to request uplift

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e1d19594c3b6

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e1d19594c3b6

Comment 14

[Edouard Oger [:eoger]]

Comment on attachment 8647319 [details] [diff] [review]
bug-1193989.patch

Approval Request Comment
[Feature/regressing bug #]: Revamping of the sync in-content preferences
[User impact if declined]: The preferences will be stretched and look very ugly on other locales.
[Describe test coverage new/current, TreeHerder]: Been on central for some time, all existing and new tests pass.
[Risks and why]: Not a lot of risks, it is mainly moving XUL nodes and changing the css to have something more responsive.
[String/UUID change made/needed]: None

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8647319 [details] [diff] [review]
bug-1193989.patch

Early in the aurora cycle, I don't think this has to ride the train as it will improve certain locales.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/96cdc9bfc651