1194025 - after clearing notifications (or last one) should say "no" instead of "0"

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Feedback, defect)

Description

[Dietrich Ayala (:dietrich)]

User-Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Humanize the machine!

Comment 1

[Mahendra Potharaju [:mahe]]

Ux Team, Please check if this message needs correction. Thanks Dietrich.

Comment 2

[Patryk Adamczyk [:patryk] UX]

Agreed. We should change the string from "0" to "No"

Comment 3

[Tiffanie Shakespeare [:tif]]

Eric is going to work with Dev. 

Thanks for pinging the UX team!

Comment 4

[Eric Pang [:epang] UX]

Guillaume, can you help with the change in comment 2?  Let me know if you can help or if you can redirect to some who can :).  Thanks!

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] gmarty:Bug-1194025-after-clearing-notifications-should-say-no-instead-of-0 > mozilla-b2g:master

Comment 6

[Guillaume Marty [:gmarty]]

Comment on attachment 8650446 [details] [review]
[gaia] gmarty:Bug-1194025-after-clearing-notifications-should-say-no-instead-of-0 > mozilla-b2g:master

Hi Stanisław, can you take a look at this patch?
I'm not sure if there is anything else to do to get this string updated in other languages.

Comment 7

[Staś Małolepszy :stas]

Comment on attachment 8650446 [details] [review]
[gaia] gmarty:Bug-1194025-after-clearing-notifications-should-say-no-instead-of-0 > mozilla-b2g:master

Hey, thanks for checking in with me.  Can we use a new string for this, please?  The reason is, the fact that l10n.js uses [zero] in this case is an implementation detail inherited from the old version of the library.  We'd like to deprecate this feature (or a bug, depending how you look at it) in the future.  Not all CLDR plural rules return 'zero' when the number is 0.  In fact, only a handful do.  So right now we need to special-case the 'zero' case (together with 'one' and 'two') to keep our translations working [1].  In the future, we'd like to just use the standard CLDR plural rules [2].  Thanks!

[1] https://github.com/mozilla-b2g/gaia/blob/c6705f739fb605031eb2a0b943ba55c64bee5a03/shared/js/l10n.js#L939-L948
[2] http://www.unicode.org/cldr/charts/27/supplemental/language_plural_rules.html

Comment 8

[Guillaume Marty [:gmarty]]

Comment on attachment 8650446 [details] [review]
[gaia] gmarty:Bug-1194025-after-clearing-notifications-should-say-no-instead-of-0 > mozilla-b2g:master

I updated the patch to reflect the changes we discussed on IRC.
Let me know if that looks good now.

Comment 9

[Staś Małolepszy :stas]

Comment on attachment 8650446 [details] [review]
[gaia] gmarty:Bug-1194025-after-clearing-notifications-should-say-no-instead-of-0 > mozilla-b2g:master

Thanks!

One nit: can you please reorder the strings in the properties file so that all statusbarNotifications sub-definitions are next to each other?

statusbarNotificationsZero=...
statusbarNotifications={[ plural(n) ]}
statusbarNotifications[one]=...
etc.

And just a thought from a second ago:  perhaps statusbarNoNotifications would be a better name?

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/94767d1a26626a2e0488a6ced23150c87687c96b

Comment 11

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: After clearing the notifications (or last one) on the notification bar, it shows "No" instead of "0".
See attachment: verified_FlameKK_v2.5.png
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150823150207
Gaia Revision          cddb9f610cbe03d0ca39d81bbdce46a0fca841ab
Gaia Date              2015-08-23 03:34:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4ccdd06e51d7209ba429196df7cab97bf66962db
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150823.184539
Firmware Date          Sun Aug 23 18:45:51 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150823221817
Gaia Revision          cddb9f610cbe03d0ca39d81bbdce46a0fca841ab
Gaia Date              2015-08-23 03:34:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4ccdd06e51d7209ba429196df7cab97bf66962db
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150823.214038
Firmware Date          Sun Aug 23 21:40:46 UTC 2015
Bootloader             s1