119406 - nsprpub/pr/include/prio.h - has incorrect name in #define

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P1)

Description

[Nick Blievers]

nsprpub/pr/include/prio.h (v3.31):
#define pr_s6_addr64 _S6_un._S6_addr64
should be 
#define pr_s6_addr64 _S6_un._S6_u64

because:
nsprpub/pr/src/misc/prnetdb.c:
struct PRIPv6Addr {
	union {
		char _s6_u8[16];
		char _s6_u16[8];
		char _s6_u32[4];
		char _s6_u64[2];
	} _S6_un;
};

This is not actually used anywhere, so not critical.
Sorry, not sure what version of nspr this is from, but its from the 
MOZILLA_0_9_7_BRANCH tag, so I assume the latest.

Comment 1

[Nick Blievers]

Attachment: nsprpub/pr/include/prio.h - #define uses incorrect variable name

Comment 2

[Wan-Teh Chang]

Good catch.  I checked in your fix into the tip and client
branch of NSPR.  Thanks!

Just curious: how did you spot the incorrect variable name?

Comment 3

[Nick Blievers]

I am having some trouble with one of the macro's in prnetdb.c that uses these
#define's... so tried changing one of the checks from 32bit to 64bit... and got
a syntax error! :)