Closed Bug 1194080 Opened 5 years ago Closed 5 years ago

Implement MP3TrackDemuxer::GetBuffered

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- affected
firefox44 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The code indicates that this is dependent on bug 1169485 to be done.

But GetBuffered() is required even without MSE.

It must be implemented if we are to enable the MP3Demuxer
Blocks: 1172419
No longer blocks: 1194079
Blocks: 1163667
Blocks: 1168435
Priority: -- → P2
Duplicate of this bug: 1202475
Blocks: 1209410
This is done by roughly estimated the duration of the MediaResource buffered range from the average bitrate.
Attachment #8668380 - Flags: review?(esawin)
Assignee: nobody → jyavenard
Comment on attachment 8668380 [details] [diff] [review]
[mp3] Implement MP3TrackDemuxer::GetBuffered().

Review of attachment 8668380 [details] [diff] [review]:
-----------------------------------------------------------------

This depends on stable/consistent values returned by MediaResource::GetLength, but so does a lot of other code.
LGTM.

::: dom/media/MP3Demuxer.h
@@ +27,5 @@
>    void NotifyDataArrived(uint32_t aLength, int64_t aOffset) override;
>    void NotifyDataRemoved() override;
> +  // Do not shift the calculated buffered range by the start time of the first
> +  // decoded frame. The mac MP3 decoder will buffer some samples and the first
> +  // frame returned has typically a start time that is non-zero ; causing our

Redundant space before ;.
Attachment #8668380 - Flags: review?(esawin) → review+
https://hg.mozilla.org/mozilla-central/rev/4e3ec1168d62
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.