1194153 - Chrome Registry's convertChromeURL shouldn't crash when given a null url

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Florian Quèze [:florian]]

Attachment: Fix

I just had a case while hacking the search service code where gChromeReg.convertChromeURL(uri); (where I later discovered uri was null) caused the browser to crash at startup.

This wasn't nice at all and I had to make a debug build to figure out what was going on. The debug build printed:
[2323] ###!!! ASSERTION: null url!: 'aChromeURI', file /Users/florian/buildhg/fx-team/chrome/nsChromeRegistry.cpp, line 267

I think this function should throw (ie. return NS_ERROR_something) when given invalid parameters, not crash.

Comment 1

[Benjamin Smedberg]

Comment on attachment 8647427 [details] [diff] [review]
Fix

I think crashing is reasonable, but in any case NS_ENSURE_* is forbidden in new code. This should probably be:

if (NS_WARN_IF(!aChromeURI)) {
  return NS_ERROR_INVALID_ARG;
}

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch v2

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6bde454912d5

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6bde454912d5