Closed Bug 1194161 Opened 9 years ago Closed 8 years ago

Update the Google play description updater to the new l10n api

Categories

(Release Engineering :: Release Automation: Other, defect)

Product:
Release Engineering
Component:
Release Automation: Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Sylvestre, Assigned: Sylvestre)

Details

Attachments

(1 file, 1 obsolete file)

foo2.diff
10.86 KB, patch
bhearsum
: review+
Details | Diff | Splinter Review
Attached patch foo2.diff (obsolete) — — Splinter Review 
Pascal did a major refactoring of his l10n interface for Google play.
It can now manage Google Play & Apple App store and also aurora/beta/release.

This required some refactoring. I removed the Google app name from the CLI. It is managed by the channel call.

I prepared the work for the app store.
Attachment #8647434 - Flags: review?(bhearsum)
Attached patch foo2.diff — — Splinter Review 
Minor fix.
Attachment #8647434 - Attachment is obsolete: true
Attachment #8647434 - Flags: review?(bhearsum)
Attachment #8647472 - Flags: review?(bhearsum)
Assignee: nobody → sledru
Comment on attachment 8647472 [details] [diff] [review]
foo2.diff

Review of attachment 8647472 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable. You may want to land this in mozilla-central as well as the independent mozharness repo. http://jordan-lund.ghost.io/mozharness-goes-live-in-the-tree/ and http://jordan-lund.ghost.io/mozharness-steps-into-the-forest/ and have more details on that.
Attachment #8647472 - Flags: review?(bhearsum) → review+
Sylvestre, anything left here?
Flags: needinfo?(sledru)
In production, thanks
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(sledru)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: