1194175 - [LockScreen] Turn off LockScreen state manager logger

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

It looks now the logger is on, so performance is affected. I now turn it off and we should think about how to control it by build flags

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] snowmantw:bug1194175-rev2 > mozilla-b2g:master

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8647508 [details] [review]
[gaia] snowmantw:bug1194175-rev2 > mozilla-b2g:master

Fix:

1. If build it with DEVICE_DEBUG=1 or REMOTE_DEBUGGER=1, the logger will be enabled.

2. After the logger is enabled, it can be turned off by setting the remote debugger as 'disabled' in developer menu.

3. But if build without such flag, this means user doesn't want to turn it on. So to turn the remote debugging setting flag on later will not turn the logger on.

4. I combine this feature with DEVICE_DEBUG=1 since I don't know whether to add a new one (it's already too much I think) flag only for turn on such specific logging function is proper or not. If it's better, I can modify the patch.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8647508 [details] [review]
[gaia] snowmantw:bug1194175-rev2 > mozilla-b2g:master

I don't think we should do this. 

1. I don't feel a strong need on being able to turn on/off without using Web Console -- developer can always turn it on/off manually by diving into the scope.

2. Toggle logging shouldn't be related to turning on-off remote debugger. Maybe reuse the gaia DUMP flag in mozSettings?

I don't really feel strongly at (1) so if you have your use cases let's just finishing up (2) and get this landed.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8647508 [details] [review]
[gaia] snowmantw:bug1194175-rev2 > mozilla-b2g:master

Updated as the above comment. Test result is green:

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=8aea7b9ce6a621fd6b6eaa28f4eae9ad0d8d00dd

And I tried it on my device manually: to turn on and off the logger with |debug.gaia.enabled| works well. So I set review again.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/1b4259db8a178e592ce50afae9f78c9c5877f666