1194198 - Unexpected error during validation

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Description

[Josh Geenen (:pi)]

Attachment: v2.0.6 of gContactSync (fails validation)

Please attach a copy of your add-on, and fill in the following information:

* Whether this error occurred during the submission of a new add-on, a new version of an existing add-on, a new file in an existing version, or an upload to the standalone validator.
  - This is a submission for a new version of an existing Thunderbird and Seamonkey add-on called gContactSync.  Re-uploading the current version, 2.0.5, fails with the same unknown error.

* Whether your add-on is listed or unlisted.
  - The add-on is listed.

* The URL where you submitted the add-on.
  - https://addons.mozilla.org/en-us/developers/addon/gcontactsync/versions#version-upload

* The approximate time you submitted the add-on, with timezone.
  - 7:30 AM GMT-500 (Central US Time)

Comment 1

[Mathieu Agopian [:magopian]]

Kris, I can reproduce locally, here's the traceback:

06:29:03 amo.validator:ERROR Unexpected error during validation: IndexError: list index out of range :/Users/mathieu/.virtualenvs/olympia/lib/python2.7/site-packages/validator/errorbundler.py:144
Traceback (most recent call last):
  File "/Users/mathieu/.virtualenvs/olympia/lib/python2.7/site-packages/validator/submain.py", line 68, in prepare_package
    test_package(err, package, path, expectation, for_appversions)
  File "/Users/mathieu/.virtualenvs/olympia/lib/python2.7/site-packages/validator/submain.py", line 157, in test_package
    test_inner_package(err, package, for_appversions)
  File "/Users/mathieu/.virtualenvs/olympia/lib/python2.7/site-packages/validator/submain.py", line 350, in test_inner_package
    test_func(err, xpi_package)
  File "/Users/mathieu/.virtualenvs/olympia/lib/python2.7/site-packages/validator/testcases/l10ncompleteness.py", line 199, in test_xpi
    locale["target"])
  File "/Users/mathieu/.virtualenvs/olympia/lib/python2.7/site-packages/validator/testcases/l10ncompleteness.py", line 329, in _compare_packages
    tar_doc = _parse_l10n_doc(tar_name, target.read(tar_name))
  File "/Users/mathieu/.virtualenvs/olympia/lib/python2.7/site-packages/validator/testcases/l10ncompleteness.py", line 389, in _parse_l10n_doc
    loc_doc = handlers[extension](wrapper)
  File "/Users/mathieu/.virtualenvs/olympia/lib/python2.7/site-packages/validator/testcases/l10n/dtd.py", line 33, in __init__
    self._parse(data)
  File "/Users/mathieu/.virtualenvs/olympia/lib/python2.7/site-packages/validator/testcases/l10n/dtd.py", line 48, in _parse
    parser.feed(split_line + "\n")
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/HTMLParser.py", line 117, in feed
    self.goahead(0)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/HTMLParser.py", line 165, in goahead
    k = self.parse_comment(i)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/markupbase.py", line 178, in parse_comment
    self.handle_comment(rawdata[i+4: j])
  File "/Users/mathieu/.virtualenvs/olympia/lib/python2.7/site-packages/validator/testcases/l10n/dtd.py", line 68, in handle_comment
    self.unknown_decl(data)
  File "/Users/mathieu/.virtualenvs/olympia/lib/python2.7/site-packages/validator/testcases/l10n/dtd.py", line 76, in unknown_decl
    if not split_decl[0] == "ENTITY" or len(split_decl) < 3:
IndexError: list index out of range

Comment 2

[Kris Maglione [:kmag]]

I came across this when testing locally, so I already have a fix for it in another PR. I'll pull out that commit and submit it separately.

Comment 3

[Kris Maglione [:kmag]]

https://github.com/mozilla/amo-validator/pull/321

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/amo-validator

https://github.com/mozilla/amo-validator/commit/c6a1e2975dd19f15a6be897beb1567d1cdfd0602
Bug 1194198: Fix DTD parser error.

https://github.com/mozilla/amo-validator/commit/9311758b901e08cbda0c9f34b5a39f6cb8160fc7
Merge pull request #321 from kmaglione/bug-1194198

Bug 1194198: Fix DTD parser error.

Comment 5

[Valentina Virlics [:vvalentina], VPN QA]

I've downloaded the attached addon and tried to validate it with the Validator, unsing FF40(Win 7) and AMO-dev. I've receive the same issue like Josh Geenen (:pi) did.
Please see the screencast: http://screencast.com/t/NOeH1uX4Qj

Reopening until further notice.

Comment 6

[Kris Maglione [:kmag]]

We didn't push a new version of the validator with this week's stage push.

Comment 7

[Valentina Virlics [:vvalentina], VPN QA]

Verified as fixed on AMO-dev FF40(Win 7).
Postfix screenshot: http://screencast.com/t/4N0PpajrABr
Closing bug.