1194217 - JavaScript Error: "TypeError: iconObject is undefined" {file: "app://system.gaiamobile.org/js/card.js" line: 298}

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Julien Wajsberg [:julienw]]

I got this error:

08-13 15:26:54.590 10490 10490 E GeckoConsole: [JavaScript Error: "TypeError: iconObject is undefined" {file: "app://system.gaiamobile.org/js/card.js" line: 298}]


I think this happens when I install an app that does not have an icon in its manifest.webapp (eg https://github.com/julienw/app-system-messages), launch it, and then display the task manager. You can install it using WebIDE or the install-to-adb tool.

Not sure what the user impact is, but could be that in this situation not all cards are displayed in the task manager -- qa could try to find out any user impact.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Doh yeah this is my bad. We handle the error case from getSiteIconUrl in card.js by calling _updateIcon with no argument, but _updateIcon still expects iconObject to be defined. We used to fallback to a default icon there but lost it recently.

Comment 2

[Pi Wei Cheng [:piwei] (inactive)]

Cards appear to be showing fine and completely functional when this issue happens. I don't see any actual user impact. I'm not sure if I installed the app correctly though because when I open the test app at comment 0 I only see a blank page? I did see the mentioned error in my log so I assumed I did it correctly.

Tested on:
Device: Aries 2.5
BuildID: 20150812231434
Gaia: 52f3ea58df38e5427f6afeb636bc6ad01d24022f
Gecko: 7649ffe28b67aa2dad0f67ea01500c0ff91b2bac
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Device: Flame 2.5
BuildID: 20150813030210
Gaia: 52f3ea58df38e5427f6afeb636bc6ad01d24022f
Gecko: 7649ffe28b67aa2dad0f67ea01500c0ff91b2bac
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Comment 3

[Gregor Wagner [:gwagner]]

No user impact afaict.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] sfoster:task-manager-empty-icon-bug-1194217 > mozilla-b2g:master

Comment 5

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8660044 [details] [review]
[gaia] sfoster:task-manager-empty-icon-bug-1194217 > mozilla-b2g:master

Fallback to the default icon defined in the stylesheet when getSiteIconUrl returns empty.

Comment 6

[Alberto Pastor [:albertopq]]

Comment on attachment 8660044 [details] [review]
[gaia] sfoster:task-manager-empty-icon-bug-1194217 > mozilla-b2g:master

Thanks!

Comment 7

[Sam Foster [:sfoster] (he/him)]

Thanks Alberto, merged to master: 
https://github.com/mozilla-b2g/gaia/commit/e6994410dcc88bfead0e44620a065220b7f12290