Closed Bug 1194267 Opened 9 years ago Closed 9 years ago

Failures and skipped tests are reported as errors

Categories

(Testing Graveyard :: external-media-tests, defect)

Product:
Testing Graveyard
Component:
external-media-tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: impossibus, Assigned: impossibus)

Details

Attachments

(1 file)

PR
53 bytes, text/x-github-pull-request
sydpolk
: review+
Details | Review 
Defining a custom failureException with @property caused MediaTestCase.run to classify failures as errors. Similarly, calling MediaTestCase.skipTest() resulted in a failure instead of a skip, because marionette_test defines its own SkipTest exception, but MediaTestCase.skipTest() raises unittest.case.SkipTest.
Attached file PR — 

        Attachment #8647541 -
        Flags: review?(spolk)

    
  

        Attachment #8647541 -
        Flags: review?(spolk) → review+

    
    

    
  
https://github.com/mjzffr/firefox-media-tests/commit/94caaf6286e0ddc4ca83e7a7657677e725898841
and deployed on pf-jenkins branch
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

    
  
Product: Testing → Testing Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: