[Music][NGA] Enable ServiceWorkers via build-time flag

RESOLVED FIXED

Status

Firefox OS
Gaia::Music
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: justindarc, Assigned: justindarc)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Since ServiceWorkers are no longer going to ship in NGA apps for v2.5, the Music NGA app needs to not use them by default. Fortunately, we should be able to re-enable them for testing via a build-time flag.
(Assignee)

Updated

3 years ago
Assignee: nobody → jdarcangelo
Created attachment 8647790 [details] [review]
[gaia] justindarc:bug1194342 > mozilla-b2g:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8647790 [details] [review]
[gaia] justindarc:bug1194342 > mozilla-b2g:master

Jim: This patch does some clean-up from the initial commit (such as pointing to Gaia's root `/shared` directory). It also does not depend on Service Workers for the backend API by default. You can still build Music NGA that *does* use Service Workers by using the `SERVICE_WORKERS=1` flag when building. This "dual backend" should be minimally invasive in our codebase since our views pull in some code that overrides `window.fetch()` to directly make a call to our backend using threads.js instead of performing an HTTP request to the Service Workers.

Tim: Francisco suggested that I flag you for review for just the root Makefile. I had to make a change to allow for the `SERVICE_WORKERS` build-time flag. I don't have strong feelings about it, so if you have an objection with the flag name, just let me know what you would prefer and I can change it.

Thanks!
Attachment #8647790 - Flags: review?(timdream)
Attachment #8647790 - Flags: review?(squibblyflabbetydoo)

Comment 3

3 years ago
Comment on attachment 8647790 [details] [review]
[gaia] justindarc:bug1194342 > mozilla-b2g:master

rs=me
Attachment #8647790 - Flags: review?(squibblyflabbetydoo) → review+
Comment on attachment 8647790 [details] [review]
[gaia] justindarc:bug1194342 > mozilla-b2g:master

Not sure this should be SERVICE_WORKERS or MUSIC_SERVICE_WORKERS? Is it possible we ended up shipping a given app w/ service worker but not other apps?
Attachment #8647790 - Flags: review?(timdream) → review+
(Assignee)

Comment 5

3 years ago
Renamed SERVICE_WORKERS to NGA_SERVICE_WORKERS to improve specificity a little bit. If we do end up shipping some apps with SW and others without, we can re-visit and rename the flag. At this point though, it seems that *no* NGA apps will ship with SW for v2.5. This flag is just for convenience to be able to build the Music NGA app with SW for testing the platform.

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/d9d99f32762975a370f1abd34a3512bd6fe29111
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.