1194351 - Make Buddyup content currently in static html localizable.

Status: RESOLVED FIXED

(support.mozilla.org :: BuddyUp, defect)

Description

[Michael Cooper [:mythmon]]

Currently Buddyup has a lot of content that is in static HTML, and so we can't localize it. Our localization system only works for Javascript and Nunjucks code.

I can think of two possible solutions to this

1) Build a new facet of the localization system that can deal with translations in static HTML. This would be weird, and unlike anything Sumo has done before. It would also result in English content loading, and then flickering to the localized content. That sounds bad.

2) Rewrite all the content in Buddyup to not be in static HTML, instead preferring Nunjucks or JS. This is probably more work, but it is a better solution in terms of user experience.

I'd rather go with #2.

Comment 1

[Michael Cooper [:mythmon]]

I talked about this with Rehan, and it should be 2 points.

Comment 2

[Michael Cooper [:mythmon]]

PR: https://github.com/mozilla/buddyup/pull/179
Merged.

Comment 3

[Michael Cooper [:mythmon]]

I have extracted and merged the strings from Buddyup and they should now be available to translate in Verbatim.

Comment 4

[Kadir Topal [:atopal]]

Hmm, something must have gone wrong. I don't see the updated strings in Verbatim, and I just checked the SVN commits, there is only the initial commit to buddyup.po. The commit yesterday only added strings to messages.po and those were — as far as I can tell — mostly about Firefox for iOS.

Comment 5

[Michael Cooper [:mythmon]]

Oops. My strings script was a little too zealous in making sure the svn repo was clean, and wiped the buddyup changes before comitting. I fixed the script, and updated svn with the correct strings.