1194354 - Add "Notes to Reviewer" Field

Status: RESOLVED INVALID

(MozReview Graveyard :: General, defect, P3)

Description

[Dan Minor [:dminor]]

We're planning to make the description field contain just the commit summary in Bug 1123139 to encourage people to write meaningful commit messages.

One use case for the description field is to indicate that this is initial work and that the review requestor is looking for feedback rather than a detailed review. This can be done in the commit message and then the commit message can be amended when the patch is updated.

Another use case is asking a reviewer to look at one section of a commit and a different reviewer to look at another section of a commit. This could be handled in the commit message or by splitting the commit into two, but it seems that it would be nice to have "Notes to Reviewer" field for this case.

Comment 1

[Dan Minor [:dminor]]

The plan is for this to be available only on the parent review request for now.

Comment 3

[Mark Côté [:mcote]]

I think this should actually be available on all commits.

Comment 4

[Mark Côté [:mcote]]

Duping this to a newer bug that has a bit more context.

Comment 5

[Botond Ballo [:botond] [back on May 21]]

I'm a bit confused.

This bug is about the patch author being able to write the reviewer a supplementary note.

Bug 1248008 seems to be about the reviewer being able to write a review comment for the commit message.

Comment 6

[Mark Côté [:mcote]]

Oh you're right.  I thought for sure this had been filed before, but I can't find it.  Huh.

Comment 7

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.