Closed Bug 1194365 Opened 4 years ago Closed 4 years ago
update the android NDK we bootstrap with
2.71 KB, patch
|Details | Diff | Splinter Review|
MozReview Request: Bug 1194365 - Bump Andoid NDK to r10e; manually install Android SDK and NDK on Mac OS X. r?mcomella
40 bytes, text/x-review-board-request
We have used NDK r10e for a couple months now.
I spent a little while today trying to figure out what was going on between what |mach bootstrap| gave me, what our android mozconfigs say, and what we actually build with. Let's fix the bootstrap part of this.
Here, let's get all the instances of r8e.
Comment on attachment 8647684 [details] [diff] [review] update the android NDK we bootstrap with Sadly, this doesn't do the trick. You'll find those URLs are 404; Google now packages a self-extracting executable. (Bonkers, but hey! It's Google.) I am not able to find archives on the web. I have WIP for using the the new .bin format which I will push.
Attachment #8647684 - Flags: review?(nalexander) → review-
Depends on: 1165460
froydn: I pushed a review-without-reviewers to https://reviewboard.mozilla.org/r/16139/, so the commits should be available. I'd like to make all platforms (Mac and Linux) use the .bin approach. I think my code above works, I just haven't tested it. I'd love to see somebody (you!) push it across the line.
(In reply to Nick Alexander :nalexander from comment #4) > I'd like to make all platforms (Mac and Linux) use the .bin approach. I > think my code above works, I just haven't tested it. I'd love to see > somebody (you!) push it across the line. I probably won't have time for it within the next week or two.
Assignee: nfroyd → nalexander
Status: NEW → ASSIGNED
Depends on: bootstrapfennec
Bug 1194365 - Bump Andoid NDK to r10e; manually install Android SDK and NDK on Mac OS X. r?mcomella This bumps the NDK version to r10e. Previously, we used brew to install android-sdk and a custom version of android-ndk. That makes it hard to control the installed versions. This installs from downloaded archives, which unifies the Mac OS X approach with the straight-forward Linux approach.
Attachment #8664475 - Flags: review?(michael.l.comella)
Comment on attachment 8664475 [details] MozReview Request: Bug 1194365 - Bump Andoid NDK to r10e; manually install Android SDK and NDK on Mac OS X. r?mcomella https://reviewboard.mozilla.org/r/19957/#review17999 I skimmed the code and it looks reasonable. I tested locally pulling down the changesets and running mach bootstrap. I have no Android env var set so the android dependencies successfully downloaded to .mozbuild (in addition my homebrew install) and I was able to successfully build, compile, and run a Fennec instance. Don't forget to update the gradle configs to look at .mozbuild for the Android SDK! ::: python/mozboot/mozboot/osx.py:338 (Diff revision 1) > + ('wget', 'wget'), I'm guessing we should dupe the wget bug over to this one?
Attachment #8664475 - Flags: review?(michael.l.comella) → review+
You need to log in before you can comment on or make changes to this bug.