Closed
Bug 1194365
Opened 9 years ago
Closed 9 years ago
update the android NDK we bootstrap with
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox44 fixed)
RESOLVED
FIXED
mozilla44
Tracking | Status | |
---|---|---|
firefox44 | --- | fixed |
People
(Reporter: froydnj, Assigned: nalexander)
References
Details
Attachments
(2 files, 1 obsolete file)
We have used NDK r10e for a couple months now.
Reporter | ||
Comment 1•9 years ago
|
||
I spent a little while today trying to figure out what was going on between what |mach bootstrap| gave me, what our android mozconfigs say, and what we actually build with. Let's fix the bootstrap part of this.
Attachment #8647626 -
Flags: review?(nalexander)
Reporter | ||
Comment 2•9 years ago
|
||
Here, let's get all the instances of r8e.
Attachment #8647626 -
Attachment is obsolete: true
Attachment #8647626 -
Flags: review?(nalexander)
Attachment #8647684 -
Flags: review?(nalexander)
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8647684 [details] [diff] [review] update the android NDK we bootstrap with Sadly, this doesn't do the trick. You'll find those URLs are 404; Google now packages a self-extracting executable. (Bonkers, but hey! It's Google.) I am not able to find archives on the web. I have WIP for using the the new .bin format which I will push.
Attachment #8647684 -
Flags: review?(nalexander) → review-
Assignee | ||
Comment 4•9 years ago
|
||
froydn: I pushed a review-without-reviewers to https://reviewboard.mozilla.org/r/16139/, so the commits should be available. I'd like to make all platforms (Mac and Linux) use the .bin approach. I think my code above works, I just haven't tested it. I'd love to see somebody (you!) push it across the line.
Flags: needinfo?(nfroyd)
Reporter | ||
Comment 5•9 years ago
|
||
(In reply to Nick Alexander :nalexander from comment #4) > I'd like to make all platforms (Mac and Linux) use the .bin approach. I > think my code above works, I just haven't tested it. I'd love to see > somebody (you!) push it across the line. I probably won't have time for it within the next week or two.
Flags: needinfo?(nfroyd)
Assignee | ||
Updated•9 years ago
|
Assignee: nfroyd → nalexander
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Depends on: bootstrapfennec
Assignee | ||
Comment 6•9 years ago
|
||
Bug 1194365 - Bump Andoid NDK to r10e; manually install Android SDK and NDK on Mac OS X. r?mcomella This bumps the NDK version to r10e. Previously, we used brew to install android-sdk and a custom version of android-ndk. That makes it hard to control the installed versions. This installs from downloaded archives, which unifies the Mac OS X approach with the straight-forward Linux approach.
Attachment #8664475 -
Flags: review?(michael.l.comella)
Builds on the implementation in bug 1171232.
Depends on: 1171232
Comment on attachment 8664475 [details] MozReview Request: Bug 1194365 - Bump Andoid NDK to r10e; manually install Android SDK and NDK on Mac OS X. r?mcomella https://reviewboard.mozilla.org/r/19957/#review17999 I skimmed the code and it looks reasonable. I tested locally pulling down the changesets and running mach bootstrap. I have no Android env var set so the android dependencies successfully downloaded to .mozbuild (in addition my homebrew install) and I was able to successfully build, compile, and run a Fennec instance. Don't forget to update the gradle configs to look at .mozbuild for the Android SDK! ::: python/mozboot/mozboot/osx.py:338 (Diff revision 1) > + ('wget', 'wget'), I'm guessing we should dupe the wget bug over to this one?
Attachment #8664475 -
Flags: review?(michael.l.comella) → review+
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5ecda9616475
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•