Remove unnecessary RemoveAllRanges call in nsDocumentViewer::SelectAll()

RESOLVED WONTFIX

Status

()

Core
Selection
RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: mystor, Assigned: mystor)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

3 years ago
Created attachment 8647658 [details] [diff] [review]
Remove unnecessary RemoveAllRanges call in nsDocumentViewer::SelectAll()

Currently nsDocumentViewer::SelectAll calls RemoveAllRanges, immediately followed by SelectAllChildren. SelectAllChildren itself calls Collapse, which handles removing the currently selected ranges from the document. Thus, this call to RemoveAllRanges is unnecessary, and can be removed.
(Assignee)

Updated

3 years ago
Assignee: nobody → michael
(Assignee)

Updated

3 years ago
Blocks: 571294
(Assignee)

Updated

3 years ago
Attachment #8647658 - Flags: review?(ehsan)
(Assignee)

Comment 2

3 years ago
Comment on attachment 8647658 [details] [diff] [review]
Remove unnecessary RemoveAllRanges call in nsDocumentViewer::SelectAll()

We don't need this anymore for bug 571294
Attachment #8647658 - Flags: review?(ehsan)
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.