1194464 - Set ACL app detail page Install button to "spinning" state

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P1)

Description

[David Durst [:ddurst]]

When the mozActivity has started the install of the ACL app, the user is seeing the ACL app detail page but has no idea the install is happening -- worse, if they hit the "Install" button, they get an error.

We should have the button reflect the usual state for install -- spinning.

Word on the street is that this is just "After redirecting to the detail page, I think we just add the class name "spinner". Once the install is done, then remove that class from the button." Of course in this case, Marketplace goes away once the install is done.

Comment 1

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/fireplace/commit/d38f1b8d74a38eb157951c908ce98e5e13c20c50

It will land in prod on Tuesday around noon, Pacific Time.

Comment 2

[krupa raj[:krupa]]

reopened since this is not working as expected.

Comment 3

[krupa raj[:krupa]]

To add more context for chuck-

STR:
1. Follow the instructions at  https://etherpad.mozilla.org/open-mobile-testing to get your 2.1 flame ready for testing
2. Launch the test app provided by Mat
3. Click on Install ACL
4. Confirm install of the app

expected behavior:
- after step #4, user is at the details page and the install button status changes to spinning to indicate dowloading in progress.
- after install, user returns to the test app

actual behavior:
- after step #4, button status remains as "install" even though download is in progress (which gives no visual indication to the end user)
- after install, user ends up in the ACL Welcome page and not the test app

Comment 4

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/fireplace/commit/a9f6e070edeebcaa18d427e9dc370030edba9847

Comment 5

[Mathieu Pillard [:mat]]

Attachment: openmobile-activity-test.zip

Test app to facilitate QA.

Comment 6

[Victor Carciu]

I verified this bug and everything is ok(after step #4 user is at the details page and the install button status changes to spinning to indicate dowloading in progress) , but when trying to install the app in order to see if after install user returns to the test app I encountered a problem on OpenMobile(waiting spinner is continuously displayed and installation is never finished)

I think that this problem is from OpenMobile and I need a confirmation from Krupa if we can close this bug or not because I am not sure if user will return to details page after a successful installation

Comment 7

[Pete Blumenthal (OpenMobile)]

This seems to not be working again. Please verify.

Comment 8

[Pete Blumenthal (OpenMobile)]

This is no longer working.

Comment 9

[Mathieu Pillard [:mat]]

Victor: yes, this is because the ACL app itself can not work on your flame device.

Can you reverify, per comment 7 and 8 it appears to be broken now ?

Comment 10

[Victor Carciu]

Yes, I can see the same issue as in comment #6

Comment 11

[Mathieu Pillard [:mat]]

Attachment: openmobile-activity-test.zip

Comment 12

[Mathieu Pillard [:mat]]

Victor and I retested twice each separately, with stage and prod, using WhatsApp and using my test app attached to this bug. I was using 2.5, he was using 2.1.

We are seeing the same thing:

- When launching WhatsApp, we see a blue screen with the WhatsApp logo... and nothing else happens.

- When using my test app, installing the ACL using the activity, we are taken to Marketplace page for ACL, we get prompted to install it automatically, and the button starts spinning. Then, when the ACL app is downloaded it's launched automatically.

  From then on we can't test more than that because the ACL app never finishes on our Flame devices, probably because it's not compatible with the chipset in the Flame.


So on our devices, the Marketplace code works fine. The issues we are encountering are in the WhatsApp app or the ACL app.

Comment 13

[David Palomino [:dpalomino]]

Hi, 

I'm seeing again this issue, but now during WA app downloading (not spinning icon displayed). However, during ACL downloading was working fine for me. I've checked this twice with the same result. 

Can you please check this?

Thanks!
David

Comment 14

[David Durst [:ddurst]]

We need ashes from someone who has a device, or something. We can't get past the ACL point on our incompatible devices.

In the app, you can search for :debug to reach the debug screen and then choose "Submit logs" -- it will show "Logs uploaded: {code}" at the bottom. Please paste that code in a comment here.

Comment 15

[David Palomino [:dpalomino]]

Hi David, 

It's "feb14". However I think it is not always happening. Trying right now it was not reproducible... 

Let me know if I can help (mail/call to me if urgent, will be quicker). 

Cheers, 
DAvid

Comment 16

[David Durst [:ddurst]]

That code appears to not work.

Video could also be helpful, but certainly more ashes would be good.

Comment 17

[David Palomino [:dpalomino]]

Hi David, 

I can't reproduce the issue now... it is failing sometimes, not always. I will try to reproduce it again... 

Cheers, 
David

Comment 18

[Mathieu Pillard [:mat]]

We can't reproduce on our own devices, so we need logs and a screencast to make any progress.

Comment 19

[David Palomino [:dpalomino]]

Clearing ni, as we were not able to reproduce it. 

Cheers, 
David

Comment 20

[Mathieu Pillard [:mat]]

Can this bug be closed then ?

Comment 21

[David Palomino [:dpalomino]]

I think so, if we see it again we can reopen... Thanks!!!

Comment 22

[Victor Carciu]

Verified as fixed based on comment #19