Closed Bug 1194472 Opened 6 years ago Closed 6 years ago

Layers backend is not fetched properly with WebGL surface sharing on GLX

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: acomminos, Assigned: acomminos)

References

Details

Attachments

(1 file, 1 obsolete file)

We only want to enable GLX surface sharing with OpenGL layers at the moment, but our check is incorrect (gfxPlatform does not have its layers backend set in the child).
This should be a sane workaround to getting the compositor backend in the child process.
Attachment #8647743 - Flags: review?(jgilbert)
Comment on attachment 8647743 [details] [diff] [review]
Correctly fetch compositor backend in WebGLContext.

Review of attachment 8647743 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLContext.h
@@ +362,5 @@
>      GLsizei DrawingBufferHeight() const {
>          return IsContextLost() ? 0 : mHeight;
>      }
>  
> +    layers::LayersBackend GetCompositorBackendType();

Try to make this a const function.
Attachment #8647743 - Flags: review?(jgilbert) → review+
Updated, thanks.

Skipping try push as GL layers with GLX isn't used on the test infrastructure.
Attachment #8647743 - Attachment is obsolete: true
Attachment #8648721 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c360730ee38a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.