1194496 - mochitest chain should insist on Promises

Status: NEW

(Core :: WebRTC, defect, P4)

Description

[Nils Ohlmeier [:drno]]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1193045#c6

It might be helpful to add a sanity check to our mochitest framework which points out function which don't return a Promise.

Note: we have quite a few functions which are synchronously blocking and don't return a Promise. So we need an exception for these.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: MozReview Request: Bug 1194496: insist on Promises as return values

Bug 1194496: insist on Promises as return values

Comment 2

[Nils Ohlmeier [:drno]]

This depends right now on bug 1193045 to land.

Comment 3

[Maire Reavy [:mreavy]]

Hey Nils, is this ready for review and landing ?

Comment 4

[Nils Ohlmeier [:drno]]

Comment on attachment 8647792 [details]
MozReview Request: Bug 1194496: insist on Promises as return values

Bug 1194496: insist on Promises as return values

Comment 5

[Nils Ohlmeier [:drno]]

With the latest patch it passes basicAudio, but as jib predicted: 48 errors in a full mochitest run. So still plenty of work left.

Comment 6

[Bulk Bug Changes for mreavy's org]

Mass change P3->P4 to align with new Mozilla triage process.

Comment 7

[Nils Ohlmeier [:drno]]

I don't have the capacity any more to work on this any time soon.