Closed Bug 1194503 Opened 4 years ago Closed 4 years ago

Make appendNotification not set accesskey="undefined" if passed a structure with no accesskey

Categories

(Toolkit :: Notifications and Alerts, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox41 --- fixed
firefox42 --- fixed
firefox43 --- fixed

People

(Reporter: Gijs, Assigned: yfdyh000, Mentored)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1192901 +++

Bug 1153198 removed the accesskey from the .properties file, but we still have an accesskey in the UI.

This is because we pass |undefined| and the code indiscriminately setAttribute's that, resulting in the string "undefined" becoming the accesskey, which shows a "U" accesskey.

We should just not do that. Yang, do you think you could write the patch for this?
Flags: needinfo?(yfdyh000)
Attached patch patch v1Splinter Review
Flags: needinfo?(yfdyh000)
Attachment #8647893 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8647893 [details] [diff] [review]
patch v1

Review of attachment 8647893 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks!
Attachment #8647893 - Flags: review?(gijskruitbosch+bugs) → review+
Assignee: nobody → yfdyh000
Status: NEW → ASSIGNED
Keywords: checkin-needed
Blocks: 1192901
https://hg.mozilla.org/mozilla-central/rev/bd5b01dfe7d7
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Comment on attachment 8647893 [details] [diff] [review]
patch v1

Approval Request Comment
[Feature/regressing bug #]: for Bug 1153198
[User impact if declined]: bug 1192901
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Low, minor changes.
[String/UUID change made/needed]: No.
Attachment #8647893 - Flags: approval-mozilla-aurora?
Comment on attachment 8647893 [details] [diff] [review]
patch v1

This should be fine on beta as well (approval request comment 5).
Attachment #8647893 - Flags: approval-mozilla-beta?
Comment on attachment 8647893 [details] [diff] [review]
patch v1

Patch has been on Nightly for 2 days and the fix is a two-liner, let's uplift to Aurora and Beta.
Attachment #8647893 - Flags: approval-mozilla-beta?
Attachment #8647893 - Flags: approval-mozilla-beta+
Attachment #8647893 - Flags: approval-mozilla-aurora?
Attachment #8647893 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.