1194556 - Client command sending NotFound code block doesn't run

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, defect)

Description

[Richard Newman [:rnewman]]

Causes the upload to fail.

2015-08-13 18:35:04.809 [Debug] [ClientsSynchronizer.swift:239] maybeUploadOurRecord(_:ifUnmodifiedSince:toServer:): Should we upload our client record? Caller = false, expired = false.
2015-08-13 18:35:04.811 [Info] [SQLiteRemoteClientsAndTabs.swift:335] getCommands(): Found 1 client sync commands in the DB.
2015-08-13 18:35:04.813 [Debug] [ClientsSynchronizer.swift:193] syncClientCommands(_:commands:clientsAndTabs:withServer:): Fetching current client record for client Tb40VvFMTUfh.
2015-08-13 18:35:04.874 [Debug] [StorageClient.swift:326] errorWrap(_:handler:): Status code: 404
2015-08-13 18:35:04.875 [Warning] [ClientsSynchronizer.swift:211] syncClientCommands(_:commands:clientsAndTabs:withServer:): Failed to fetch record with GUID Tb40VvFMTUfh.
2015-08-13 18:35:04.875 [Error] [ClientsSynchronizer.swift:226] syncClientCommands(_:commands:clientsAndTabs:withServer:): Client Tb40VvFMTUfh commands upload failed: No remote client for GUID

Comment 1

[Richard Newman [:rnewman]]

Attachment: Pull req.

Comment 2

[Stephan Leroux [:sleroux]]

Comment on attachment 8647881 [details] [review]
Pull req.

Code changes look good. Sorry for missing that <ClientPayload> error earlier - doesn't seem that ClientPayload isn't related to NSURLHTTPResponse in anyway.

Comment 3

[Richard Newman [:rnewman]]

https://github.com/mozilla/firefox-ios/commit/36925be305062f43e9ee56b69f46514ef2d88273