Mismatch between clients and tabs collection can cause failures to sync tabs

RESOLVED FIXED

Status

()

Firefox for iOS
Sync
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rnewman, Assigned: rnewman)

Tracking

unspecified
All
iOS

Firefox Tracking Flags

(fxios+)

Details

Attachments

(1 attachment)

47 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review | Splinter Review
(Assignee)

Description

2 years ago
If tabs contains a record that doesn't have a corresponding client record:

2015-08-13 19:32:50.151 [Info] [TabsSynchronizer.swift:88] doInsert: Inserting 1 tabs for client yPXUXf8u21cQ.
2015-08-13 19:32:50.152 [Debug] [SwiftData.swift:133] transaction: Op in transaction failed. Rolling back.
2015-08-13 19:32:50.152 [Warning] [TabsSynchronizer.swift:91] doInsert: Inserting tabs failed for client yPXUXf8u21cQ


This'll cause the sync to be marked as failed.
(Assignee)

Updated

2 years ago
Summary: Mismatch between clients and tabs collection can cause client failures → Mismatch between clients and tabs collection can cause failures to sync tabs
(Assignee)

Comment 1

2 years ago
Created attachment 8647882 [details] [review]
Pull req.

Thorough review, please. Last commit not strictly necessary.
Attachment #8647882 - Flags: review?(sleroux)
Comment on attachment 8647882 [details] [review]
Pull req.

Code looks good with some nits and a question at the end. Curious if returning 0 will effect any other call sites.
Attachment #8647882 - Flags: review?(sleroux) → review+
(Assignee)

Comment 3

2 years ago
https://github.com/mozilla/firefox-ios/commit/36925be305062f43e9ee56b69f46514ef2d88273
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
tracking-fxios: --- → +
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.