If tabs contains a record that doesn't have a corresponding client record: 2015-08-13 19:32:50.151 [Info] [TabsSynchronizer.swift:88] doInsert: Inserting 1 tabs for client yPXUXf8u21cQ. 2015-08-13 19:32:50.152 [Debug] [SwiftData.swift:133] transaction: Op in transaction failed. Rolling back. 2015-08-13 19:32:50.152 [Warning] [TabsSynchronizer.swift:91] doInsert: Inserting tabs failed for client yPXUXf8u21cQ This'll cause the sync to be marked as failed.
Created attachment 8647882 [details] [review] Pull req. Thorough review, please. Last commit not strictly necessary.
Comment on attachment 8647882 [details] [review] Pull req. Code looks good with some nits and a question at the end. Curious if returning 0 will effect any other call sites.