1194659 - Back/forward are not visually disabled on phone

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

With the current Nightly version disabled menu items in the overflow menu (back, forward, share, ..) do not look disabled (grayed out) anymore.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: disabled-forward-button.png

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8647986 [details]
disabled-forward-button.png

This is a 'forward' button. :)

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I can repro on my N4 but not my N7 and it only appears to affect the back/forward buttons.

Likely regression from bug 1179479 (but uncovered by bug 1193950).

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #3)
> Likely regression from bug 1179479 (but uncovered by bug 1193950).

Yep. Before this code relied on alpha state but that was removed in bug 1179479 so now the state never changes. We need to introduce a tintlist, like we do for tablet [1].

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/values-large-v11/styles.xml?rev=9b6e54ff3cb3#46

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1194659 - Tint menu on phones. r=mhaigh

Bug 1194659 - Tint menu on phones. r=mhaigh

We were doing this on tablets but I forgot to add the lines to make it work on
phones.

Comment 6

[Martyn Haigh (:mhaigh)]

Comment on attachment 8648289 [details]
MozReview Request: Bug 1194659 - Tint menu on phones. r=mhaigh

https://reviewboard.mozilla.org/r/16177/#review14487

Ship It!

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

url:        https://hg.mozilla.org/integration/fx-team/rev/076d3437d5facbda8e297fb36d6da316f8192126
changeset:  076d3437d5facbda8e297fb36d6da316f8192126
user:       Michael Comella <[e-mail]>
date:       Fri Aug 14 15:28:16 2015 -0700
description:
Bug 1194659 - Tint menu on phones. r=mhaigh

We were doing this on tablets but I forgot to add the lines to make it work on
phones.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8648289 [details]
MozReview Request: Bug 1194659 - Tint menu on phones. r=mhaigh

Approval Request Comment
[Feature/regressing bug #]: Implemented in bug 1179479 but does not appear until bug 1193950 fixes the former.

[User impact if declined]: Users on phones have disabled buttons in the menu looking enabled.

[Describe test coverage new/current, TreeHerder]: Tested locally on Android 4+ phone and GB phone.
[Risks and why]: Minimal – I reuse a style created in the previous bugs but apply it to phone as well. In the worst case, I missed some testing some configuration and I have another small fix like this.

[String/UUID change made/needed]: None.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/076d3437d5fa

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8648289 [details]
MozReview Request: Bug 1194659 - Tint menu on phones. r=mhaigh

Bad UX, taking this fix.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4345fbf90ea4