1194689 - Bookmarks.jsm:1257:0 throws an error when importing data from Google Chrome

Status: RESOLVED DUPLICATE of bug 1212297

(Firefox :: Migration, defect)

Description

[Andrei Vaida [:avaida]]

Reproducible on:
* 43.0a1 (2015-08-13)
* 41.0b1 
* 40.0.2 (20150812163655)

Affected platforms:
* Windows 7 (x64)
* Ubuntu 14.04 (x86)

Preconditions:
* Google Chrome is installed and running
* Google Chrome has a custom homepage set
* Google Chrome has a reasonable amount of browsing history
* Google Chrome has a few saved bookmarks

Steps to reproduce:
1. Launch Firefox for the first time (using a clean profile).
2. Click "Show all bookmarks" and select "Import Settings and Data" from the top menu of the Library.
3. Follow the import process and make sure you select "Chrome" from the list of browsers.
4. Check the Browser Console.

Expected result:
All the selected data is successfully imported to Firefox and no errors are thrown for this process.

Actual result:
All the data is imported, except for browsing history and the following error is thrown in the Browser Console by Bookmarks.jsm:1257:0:
> Invalid value for property 'url': chrome://bookmarks/

Notes:
* This issue is NOT reproducible on Mac OS X 10.10.4.
* Also NOT reproducible while importing data from Safari or IE.
* Latest Google Chrome version was used to replicate this.

Comment 1

[Andrei Vaida [:avaida]]

Please note that this is also affecting Aurora 42.0a2 (2015-08-13), both with and without e10s.

Comment 2

[Matthew N. [:MattN]]

(In reply to Andrei Vaida, QA [:avaida] from comment #0)
> Reproducible on:
> * 43.0a1 (2015-08-13)

> * Google Chrome is installed and running

Does this happen if Chrome isn't running? We added a warning in bold for 42+ for Chrome that tells you to close it before the import. Did you see that?

Comment 3

[Andrei Vaida [:avaida]]

(In reply to Matthew N. [:MattN] from comment #2)
> We added a warning in bold for 42+
> for Chrome that tells you to close it before the import. Did you see that?
I did see the warning, but this issue was uncovered during Negative Testing.

> Does this happen if Chrome isn't running?
Initially, I didn't notice the error getting thrown while Chrome was not running, but as of Aurora 42.0a2 (2015-08-17), the error gets thrown with Chrome both running and closed.

Comment 4

[Matthew N. [:MattN]]

Looks like we should ignore chrome URIs when importing. We should import all history but the chrome URI(s) when Chrome isn't running. Can you check if this is true?

Comment 5

[Andrei Vaida [:avaida]]

(In reply to Matthew N. [:MattN] from comment #4)
> Looks like we should ignore chrome URIs when importing. We should import all
> history but the chrome URI(s) when Chrome isn't running. Can you check if
> this is true?

Firefox is importing (or trying to) chrome URIs no matter the state in which Google Chrome is currently on, running or closed. As mentioned in Comment 3, I've imported data while having Chrome closed and also while having it running in parallel and in both cases Bookmarks.jsm:1257:0 was throwing:
> Invalid value for property 'url': chrome://bookmarks/

I hope this answers your question, let me know if you need any further information.

Comment 6

[Matthew N. [:MattN]]

My question is whether the rest of history (everything but chrome URIs) is still imported when this error happens.

Comment 7

[Andrei Vaida [:avaida]]

(In reply to Matthew N. [:MattN] from comment #6)
> My question is whether the rest of history (everything but chrome URIs) is
> still imported when this error happens.

Yes, the rest of the history is still imported.

Comment 8

[:Gijs (he/him)]

This was fixed in bug 1212297.