1194736 - [System] windo.open from insdie an app looks like the window is moved down

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

When performing a |window.open| inside an app this new window looks like is moved dow some pixeles.

You can find this in contacts, when you click on 'find duplicates' (in the contact detail), or importing contacts (from google or hotmail).

Also if you debug any other application, and do a window.open('http://anyurl.com') without internet connection, you will see that the 404 error page that we display is also suffering from this.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: 2015-08-09-23-24-19.png

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

[Blocking Requested - why for this release]:

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 1168951 seems to have caused this issue.  Ben can you please take a look at the pushlog?

B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 2.5
BuildID: 20150804113944
Gaia: c5425d9f1f5184731a59ed4bc99295acbde30390
Gecko: 05c1a5efb140
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 42.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

First Broken 
Environmental Variables:
Device: Flame 2.5
BuildID: 20150804124748
Gaia: c41d7f1676c4e98c8fc6b8eb46e8d27a6ccdd91c
Gecko: e94d967bc470
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 42.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Last Working gaia / First Broken gecko - Issue does NOT occur
Gaia: c5425d9f1f5184731a59ed4bc99295acbde30390
Gecko: e94d967bc470

First Broken gaia / Last Working gecko - Issue DOES occur
Gaia: c41d7f1676c4e98c8fc6b8eb46e8d27a6ccdd91c
Gecko: 05c1a5efb140

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/c5425d9f1f5184731a59ed4bc99295acbde30390...c41d7f1676c4e98c8fc6b8eb46e8d27a6ccdd91c

Comment 4

[Etienne Segonzac (:etienne)]

Reverting bug 1168951 is fixing the issue.
Ben, Alberto, can you take a look?

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1194736-window-open-moved > mozilla-b2g:master

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1194736-window-open-moved-2 > mozilla-b2g:master

Comment 7

[Alberto Pastor [:albertopq]]

Comment on attachment 8656987 [details] [review]
[gaia] albertopq:1194736-window-open-moved-2 > mozilla-b2g:master

This was added for unpinning the chrome on location changes, but we should consider non collapsible chromes too.

Comment 8

[Ben Francis [:benfrancis]]

Comment on attachment 8656987 [details] [review]
[gaia] albertopq:1194736-window-open-moved-2 > mozilla-b2g:master

Thanks Alberto

Comment 9

[Ben Francis [:benfrancis]]

https://github.com/mozilla-b2g/gaia/commit/03be7d8918bed58c92a40bba211bbbc97a0e516a