Closed Bug 1194738 Opened 6 years ago Closed 6 years ago

Drop some obsolete pref handling, and some old room conversation styles

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Iteration:
43.1 - Aug 24
Tracking Status
firefox43 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

I noticed we still reference a couple of loop.seenToS in places which are obsolete since we changed the FTU flow.

Also, there's some old .room-conversation css that's just no longer used, so we should drop that:

http://mxr.mozilla.org/mozilla-central/search?string=room-conversation

(room-conversation-wrapper *is* used).
Comment on attachment 8648083 [details] [diff] [review]
Drop some obsolete pref handling from Loop, and some old room conversation styles.

Review of attachment 8648083 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. I wonder how much unused code like this we still have laying around.
Attachment #8648083 - Flags: review?(andrei.br92) → review+
https://hg.mozilla.org/mozilla-central/rev/a303d8119dc8
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Iteration: --- → 43.1 - Aug 24
You need to log in before you can comment on or make changes to this bug.