Closed
Bug 1194738
Opened 9 years ago
Closed 9 years ago
Drop some obsolete pref handling, and some old room conversation styles
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox43 fixed)
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
4.55 KB,
patch
|
andreio
:
review+
|
Details | Diff | Splinter Review |
I noticed we still reference a couple of loop.seenToS in places which are obsolete since we changed the FTU flow.
Also, there's some old .room-conversation css that's just no longer used, so we should drop that:
http://mxr.mozilla.org/mozilla-central/search?string=room-conversation
(room-conversation-wrapper *is* used).
Assignee | ||
Comment 1•9 years ago
|
||
Simple tidy up patch.
Attachment #8648083 -
Flags: review?(andrei.br92)
Comment 2•9 years ago
|
||
Comment on attachment 8648083 [details] [diff] [review]
Drop some obsolete pref handling from Loop, and some old room conversation styles.
Review of attachment 8648083 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. I wonder how much unused code like this we still have laying around.
Attachment #8648083 -
Flags: review?(andrei.br92) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Updated•9 years ago
|
Iteration: --- → 43.1 - Aug 24
You need to log in
before you can comment on or make changes to this bug.
Description
•