Add a "last_modified" column to exclusion profiles table

RESOLVED FIXED

Status

P3
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: KWierso, Assigned: mdoglio)

Tracking

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
emorley
: review+
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
I'd like it if exclusion profiles returned a timestamp of the most recent time they were updated.
(Reporter)

Comment 1

3 years ago
This would help me do things like notify all clients when the active exclusion profiles have been update <somewhere else>, prompting them to refresh to pick up the new changes.
(Reporter)

Comment 2

3 years ago
Mauro said he'd take a look at this sometime next week, because Mauro is good people. :)
Assignee: nobody → mdoglio

Updated

3 years ago
Priority: -- → P3
(Reporter)

Comment 3

3 years ago
Mauro, ping? :)
Flags: needinfo?(mdoglio)
(Assignee)

Comment 4

3 years ago
Created attachment 8659861 [details] [review]
PR 957
Flags: needinfo?(mdoglio)
Attachment #8659861 - Flags: review?(emorley)
(Assignee)

Comment 5

3 years ago
To land this on staging/production we need a bit of coordination because there's a db change.

Updated

3 years ago
Attachment #8659861 - Flags: review?(emorley) → review+
(Assignee)

Comment 7

3 years ago
I applied these db schema changes to both staging and production:
alter table `exclusion_profile` add column `modified` datetime default CURRENT_TIMESTAMP;
alter table `exclusion_profile` modify column `modified` datetime NOT NULL;
(Assignee)

Comment 8

3 years ago
I actually set `DEFAULT CURRENT_TIMESTAMP` so that we don't get errors before we land the code:
alter table `exclusion_profile` modify column `modified` datetime default CURRENT_TIMESTAMP;

Comment 9

3 years ago
(In reply to Mauro Doglio [:mdoglio] from comment #7)
> I applied these db schema changes to both staging and production:

Could you also update Heroku's RDS instance please :-)
Flags: needinfo?(mdoglio)
(Assignee)

Comment 10

3 years ago
Ooops I forgot about the heroku deployment. Done.
Flags: needinfo?(mdoglio)
Thank you :-)
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

2 years ago
Depends on: 1304078
You need to log in before you can comment on or make changes to this bug.