1194829 - Rename sweep to sweepChildren because shu said so

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

<shu> jandem: if they are both dead, we should not be inside IonCacheEntry::sweep
<shu> jandem: that sweep is better named as sweepChildren
<jandem> shu: ah i see, makes sense
<sfink> shu: is that also true of BaselineEntry and IonEntry? s/sweep/sweepChildren/, I mean. (I'm not actually following your conversation, just saw that last line)
<cloudshu> sfink: it is

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Rename sweep to sweepChildren because shu said so

Comment 2

[Shu-yu Guo [:shu]]

Comment on attachment 8648187 [details] [diff] [review]
Rename sweep to sweepChildren because shu said so

Review of attachment 8648187 [details] [diff] [review]:
-----------------------------------------------------------------

Can't argue with that! Thanks.

::: js/src/jit/JitcodeMap.h
@@ +930,5 @@
>          }
>          return markedAny;
>      }
>  
>      void sweep(JSRuntime* rt) {

This should also be sweepChildren.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3764bcb8edd1

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3764bcb8edd1