If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Rename sweep to sweepChildren because shu said so

RESOLVED FIXED in Firefox 43

Status

()

Core
JavaScript Engine
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

unspecified
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
<shu> jandem: if they are both dead, we should not be inside IonCacheEntry::sweep
<shu> jandem: that sweep is better named as sweepChildren
<jandem> shu: ah i see, makes sense
<sfink> shu: is that also true of BaselineEntry and IonEntry? s/sweep/sweepChildren/, I mean. (I'm not actually following your conversation, just saw that last line)
<cloudshu> sfink: it is
(Assignee)

Comment 1

2 years ago
Created attachment 8648187 [details] [diff] [review]
Rename sweep to sweepChildren because shu said so
Attachment #8648187 - Flags: review?(shu)

Comment 2

2 years ago
Comment on attachment 8648187 [details] [diff] [review]
Rename sweep to sweepChildren because shu said so

Review of attachment 8648187 [details] [diff] [review]:
-----------------------------------------------------------------

Can't argue with that! Thanks.

::: js/src/jit/JitcodeMap.h
@@ +930,5 @@
>          }
>          return markedAny;
>      }
>  
>      void sweep(JSRuntime* rt) {

This should also be sweepChildren.
Attachment #8648187 - Flags: review?(shu) → review+

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3764bcb8edd1
https://hg.mozilla.org/mozilla-central/rev/3764bcb8edd1
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.