Closed
Bug 1194838
Opened 9 years ago
Closed 9 years ago
Mark gc::Cell as a GCType
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: sfink, Assigned: sfink)
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
terrence
:
review+
|
Details | Diff | Splinter Review |
When reviewing fitzgen's patch, I realized that gc::Cell is currently not considered to be a GCType. :-( Given that I still want to make just about all GCPointers to be inferred from the class hierarchy, this is dumb.
|
Assignee | |
Comment 1•9 years ago
|
||
Tested with https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/sfink@mozilla.com-495846a62ee6120d473d3e66c73e599786a55767/try-linux64-sh-haz/hazards.txt.gz where I added a dummy hazard and made sure it got caught. (Did I mention that I should be writing a test suite for tha analysis?)
Attachment #8648206 -
Flags: review?(terrence)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8648206 [details] [diff] [review] Mark gc::Cell as a GCType Review of attachment 8648206 [details] [diff] [review]: ----------------------------------------------------------------- \o/
Attachment #8648206 -
Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/0b962c67da9c
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•