Closed Bug 1194838 Opened 5 years ago Closed 5 years ago

Mark gc::Cell as a GCType

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(1 file)

When reviewing fitzgen's patch, I realized that gc::Cell is currently not considered to be a GCType. :-( Given that I still want to make just about all GCPointers to be inferred from the class hierarchy, this is dumb.
Tested with https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/sfink@mozilla.com-495846a62ee6120d473d3e66c73e599786a55767/try-linux64-sh-haz/hazards.txt.gz where I added a dummy hazard and made sure it got caught. (Did I mention that I should be writing a test suite for tha analysis?)
Attachment #8648206 - Flags: review?(terrence)
Comment on attachment 8648206 [details] [diff] [review]
Mark gc::Cell as a GCType

Review of attachment 8648206 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8648206 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/0b962c67da9c
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.