1194863 - Detect and report production builds

Status: RESOLVED FIXED

(Firefox OS Graveyard :: B2gInstaller, defect)

Description

[Dale Harvey (:daleharvey)]

So I flashed a production build on my phone, now we attempt to summon root in the installer and cant

Comment 1

[:gerard-majax]

(In reply to Dale Harvey (:daleharvey) from comment #0)
> So I flashed a production build on my phone, now we attempt to summon root
> in the installer and cant

So on Nexus 4/5 devices for which we currently rely on pulling blobs from the device, this is not a big deal and we can do the job without the root. Maybe we should augment devices.json and add this information on a manual basis?

Comment 2

[Dale Harvey (:daleharvey)]

Yeh adding to devices.json and not going into root for devices we dont need it sounds like a good idea

Comment 3

[:gerard-majax]

Attachment: WIP PR

Comment 4

[:gerard-majax]

Comment on attachment 8658226 [details] [review]
WIP PR

So I consider that any device defaults to requiring root. Except those with the "requiresRoot: false" properly in the devices.json.

I checked on my Z3c (only device I have with me) and it did the job of not forcing root when I used the blobfree distribution that had "requiresRoot: false".

Comment 5

[Dale Harvey (:daleharvey)]

Comment on attachment 8658226 [details] [review]
WIP PR

This looks good to me, gave it a basic test run and doesnt look like any breakages, cheers

Comment 6

[:gerard-majax]

https://github.com/mozilla-b2g/b2g-installer/commit/782983a6ba04b3ebf1ca667a0936d59f46a703c9