1194905 - Build failure on armhf

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

gcc -o bilinearpredict_neon.o -c -I../../dist/system_wrappers -include /«PKGBUILDDIR»/config/gcc_hidden.h -DHAVE_CONFIG_H='vpx_config.h' -DMOZ_GLUE_IN_PROGRAM -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -I/«PKGBUILDDIR»/media/libvpx -I.  -I../../dist/include   -I/«PKGBUILDDIR»/build-browser/dist/include/nspr -I/«PKGBUILDDIR»/build-browser/dist/include/nss       -fPIC  -D_FORTIFY_SOURCE=2 -include ../../mozilla-config.h -DMOZILLA_CLIENT -MD -MP -MF .deps/bilinearpredict_neon.o.pp -D_FORTIFY_SOURCE=2 -Wall -Wdeclaration-after-statement -Wempty-body -Wpointer-to-int-cast -Wsign-compare -Wtype-limits -Wno-unused -fstack-protector-strong -Wformat -Werror=format-security -std=gnu99 -fgnu89-inline -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe  -DNDEBUG -DTRIMMED -g -freorder-blocks -Os -fomit-frame-pointer -Wno-sign-compare  -march=armv7-a -mthumb -mfloat-abi=softfp -mfpu=neon  /«PKGBUILDDIR»/media/libvpx/vp8/common/arm/neon/bilinearpredict_neon.c
copymem_neon.o
In file included from /usr/include/features.h:398:0,
                 from ../../dist/system_wrappers/features.h:3,
                 from /usr/include/stdint.h:25,
                 from /usr/lib/gcc/arm-linux-gnueabihf/4.9/include/stdint.h:9,
                 from ../../dist/system_wrappers/stdint.h:3,
                 from /usr/lib/gcc/arm-linux-gnueabihf/4.9/include/arm_neon.h:38,
                 from /«PKGBUILDDIR»/media/libvpx/vp8/common/arm/neon/bilinearpredict_neon.c:11:
/usr/include/arm-linux-gnueabihf/gnu/stubs.h:7:29: fatal error: gnu/stubs-soft.h: No such file or directory
 # include <gnu/stubs-soft.h>
                             ^
compilation terminated.


The problem is that we're passing -mfloat-abi=softfp, which is not the right ABI for hard-float ARM.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Build libvpx neon code without -mthumb and -mfloat-abi=softfp

-mfloat-abi=softfp is hardcoding an ABI that may not match everything else
in Gecko, which is bound to fail. It's also unrelated to building NEON code.
-mthumb is also unrelated to building NEON code, and should be left as it
is for everything else.
Now, interestingly, we also have a VPX_ASFLAGS variable that just contains
the right things instead of hardcoding them in the moz.build, so just use
that instead.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2db4b0ef03a7

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2db4b0ef03a7