Closed Bug 1194935 Opened 4 years ago Closed 4 years ago

kill_and_get_minidump doesn't work on win64

Categories

(Testing :: Mozbase, defect)

defect
Not set

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(1 file)

We're writing a 0 length dump. GetLastError leads me to http://stackoverflow.com/a/8835305 -- writing a dump of a 64 bit process (Firefox) from a 32 bit process (python) doesn't seem like something that's going to work.
:-/ We could write a little C++ helper app to do the dump writing, and compile that as a 64-bit binary.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #1)
> :-/ We could write a little C++ helper app to do the dump writing, and
> compile that as a 64-bit binary.

I'll give it a shot.
Assignee: nobody → cmanchester
(In reply to Chris Manchester [:chmanchester] from comment #3)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=83ac13fd8d78

This is working pretty well. I didn't make it unicode safe, but the other code path for kill_and_get_minidump does, so I'll do that now.
Bug 1194935 - Add a C++ implementation of kill_and_get_minidump as part of the build to accodomate dumping 64 bit Firefox from 32 bit python.
Attachment #8649598 - Flags: review?(ted)
Comment on attachment 8649598 [details]
MozReview Request: Bug 1194935 - Add a C++ implementation of kill_and_get_minidump as part of the build to accommodate dumping 64 bit Firefox from 32 bit python.

Bug 1194935 - Add a C++ implementation of kill_and_get_minidump as part of the build to accommodate dumping 64 bit Firefox from 32 bit python.
Attachment #8649598 - Attachment description: MozReview Request: Bug 1194935 - Add a C++ implementation of kill_and_get_minidump as part of the build to accodomate dumping 64 bit Firefox from 32 bit python. → MozReview Request: Bug 1194935 - Add a C++ implementation of kill_and_get_minidump as part of the build to accommodate dumping 64 bit Firefox from 32 bit python.
Comment on attachment 8649598 [details]
MozReview Request: Bug 1194935 - Add a C++ implementation of kill_and_get_minidump as part of the build to accommodate dumping 64 bit Firefox from 32 bit python.

https://reviewboard.mozilla.org/r/16437/#review28981

Sorry I let this sit so long. :-(

::: testing/mozbase/mozcrash/mozcrash/mozcrash.py:377
(Diff revision 2)
> +            # we're running a python compiled for a different architecture.

I think I would move the explanation (dumping cross-architecure) up to the top of the block here to make it a little clearer.

::: testing/mozbase/mozcrash/mozcrash/mozcrash.py:391
(Diff revision 2)
> +            log.info("minidumpwriter status: %d" % status)

Do you care about failing on failure here? You could use subprocess.check_call. I feel like we should print some sort of failure line if this fails, certainly, but if it turns out to be ugly to plumb that up through the harness you could punt on it.

::: testing/tools/minidumpwriter/minidumpwriter.cpp:59
(Diff revision 2)
> +  return rv;

You never actually set rv=0 anywhere, do you?
Attachment #8649598 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/d18ca24050b7
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Depends on: 1244770
You need to log in before you can comment on or make changes to this bug.