1194943 - Consolidate URL and search bar :hover and [focused] border styling across Windows Vista / 7 and 8

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

On Windows 8 we use the same hardcoded border color as on Windows Vista and 7 for the default state, but strangely not the accompanying colors for :hover and [focused]. This patch removes this inconsistency.

Alternatively, we could make Windows 8 use the Windows 10 styling. I think this would actually make sense but it would be a more radical change from what we've been doing on Windows 8.

Comment 1

[:Gijs (he/him)]

Comment on attachment 8648347 [details] [diff] [review]
patch

Review of attachment 8648347 [details] [diff] [review]:
-----------------------------------------------------------------

Code-wise, this looks excellent.

Visually, I'm not entirely convinced. I rather liked the darker blue for the focused state. It also seems like it matches the hover state for the toolbarbuttons on the bookmarks bar (caused by moz-appearance: toolbarbutton, so not entirely sure what the colors are there and judging purely by eye) better. Is that just me? Maybe check in with Philipp/Steven?

Comment 2

[Dão Gottwald [:dao]]

(In reply to :Gijs Kruitbosch from comment #1)
> Comment on attachment 8648347 [details] [diff] [review]
> patch
> 
> Review of attachment 8648347 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Code-wise, this looks excellent.
> 
> Visually, I'm not entirely convinced. I rather liked the darker blue for the
> focused state. It also seems like it matches the hover state for the
> toolbarbuttons on the bookmarks bar

I don't think we should over-rotate on this. Windows 8 should soon be a walking dead thanks to the free and aggressive Win10 upgrade. Generally I think our quality on 8 will benefit from treating it like 7 or 10 where appropriate rather than having special treatment that engineers and testers are increasingly unlikely to dogfood.

Comment 3

[Dão Gottwald [:dao]]

Philipp, do you have thoughts on this? Should we use the URL and search bar's hover and focused styling we introduced for Windows 10 on Windows 8 too? If not, I think we should align it with the Windows 7 style as done by my patch; this would be a rather subtle change from what we're currently doing on Windows 8.

Comment 4

[Dão Gottwald [:dao]]

Attachment: alternative patch

Here's another option. The focus color hardcoded for 7 is very close to the native Highlight color, so by just using that we can get the desired blue shades across the board.

Comment 5

[:Gijs (he/him)]

Comment on attachment 8652849 [details] [diff] [review]
alternative patch

Yes, I prefer this. Thanks!

(I also ran into bug 1010676 when reviewing this, and I wonder if we should port the fix you wrote in bug 550366 to the new-style customization mode, because bug 559561 doesn't seem to be getting too much traction...)

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/719b74e30b3e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/719b74e30b3e