Closed
Bug 1194961
Opened 9 years ago
Closed 9 years ago
Remove obsolete border-radius rule for the location bar and search bar
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: dao, Assigned: c0mrad3, Mentored)
Details
(Whiteboard: [good first bug][lang=css])
Attachments
(1 file, 1 obsolete file)
944 bytes,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
We set a border-radius for Windows XP, Vista and 7 here: http://hg.mozilla.org/mozilla-central/annotate/2ddfc9180971/browser/themes/windows/browser.css#l1238 And then we override that most of the time here: http://hg.mozilla.org/mozilla-central/annotate/2ddfc9180971/browser/themes/windows/browser.css#l1247 We should remove the first rule.
Assignee | ||
Comment 1•9 years ago
|
||
I would like to work on this bug, please assign it to me
Flags: needinfo?(dao)
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → dhanvicse
Flags: needinfo?(dao)
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•9 years ago
|
||
I think this is the simple way to remove the line but I not not sure though, I will send the other series of patches, you decide which is the right way :)
Flags: needinfo?(dao)
Attachment #8649337 -
Flags: review?(dao)
Reporter | ||
Comment 3•9 years ago
|
||
Comment on attachment 8649337 [details] [diff] [review] Bug-1194961.patch > @media (-moz-os-version: windows-xp), > (-moz-os-version: windows-vista), > (-moz-os-version: windows-win7) { > #urlbar, > .searchbar-textbox { >- border-radius: 2px; > } > } Please remove the whole block, as it's empty and useless otherwise.
Flags: needinfo?(dao)
Attachment #8649337 -
Flags: review?(dao)
Reporter | ||
Comment 5•9 years ago
|
||
Comment on attachment 8649381 [details] [diff] [review] Bug-1194961-v2.patch Thanks!
Attachment #8649381 -
Flags: review?(dao) → review+
Reporter | ||
Updated•9 years ago
|
Attachment #8649337 -
Attachment is obsolete: true
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d0810e607e7d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in
before you can comment on or make changes to this bug.
Description
•